Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wrap stack entry points for error reporting #7353

Closed
cramforce opened this issue Feb 4, 2017 · 7 comments
Closed

Wrap stack entry points for error reporting #7353

cramforce opened this issue Feb 4, 2017 · 7 comments
Assignees
@cramforce
Labels
WG: infra
Milestone
New FRs

Comments

@cramforce
Copy link
Member

Due to https://blog.sentry.io/2016/05/17/what-is-script-error.html we get bad error reports in many cases.

While we will do the CORS based workaround, but that does not work in Safari.

For Safari we would need to do stack entry point instrumentation to be able to use try-catch. In particular for Promises this would, however, be really slow.
@cramforce cramforce added this to the New FRs milestone Feb 4, 2017
@cramforce cramforce self-assigned this Feb 4, 2017
@cramforce
Copy link
Member Author

See b/35002808 tracking CORS changes.

@dknecht
Copy link
Contributor

dknecht commented Feb 4, 2017

Cc: @ampproject/cloudflare
We will need to update also.

@cramforce cramforce mentioned this issue Feb 5, 2017
Merged
cramforce added a commit to cramforce/amphtml that referenced this issue Feb 5, 2017
@cramforce
Directly report logged errors instead of relying on rethrowing
a88c034 
…and then catching the `error` event.

Part of ampproject#7353
@cramforce cramforce mentioned this issue Feb 5, 2017
Merged
cramforce added a commit to cramforce/amphtml that referenced this issue Feb 6, 2017
@cramforce
Directly report errors for browser events and timer.
4b5e5e3 
Part of ampproject#7353
@cramforce cramforce mentioned this issue Feb 6, 2017
Merged
cramforce added a commit to cramforce/amphtml that referenced this issue Feb 6, 2017
@cramforce
Throttle "Script error." reports.
b9cef76 
These contain zero information and so we only care about the count, but not about getting every single one.

See ampproject#7353 for context.
@cramforce cramforce mentioned this issue Feb 6, 2017
Merged
cramforce added a commit that referenced this issue Feb 6, 2017
@cramforce
Throttle "Script error." reports. (#7371)
9605919 
These contain zero information and so we only care about the count, but not about getting every single one.

See #7353 for context.
@cramforce cramforce mentioned this issue Feb 6, 2017
Closed
cramforce added a commit that referenced this issue Feb 6, 2017
@cramforce
Directly report logged errors instead of relying on rethrowing (#7358)
7e15764 
…and then catching the `error` event.

Part of #7353
@dknecht
Copy link
Contributor

dknecht commented Feb 6, 2017

@cramforce will this require cache level CORS changes

cramforce added a commit to cramforce/amphtml that referenced this issue Feb 6, 2017
@cramforce
Directly report errors for browser events and timer.
08c0e01 
Part of ampproject#7353
@cramforce
Copy link
Member Author

@dknecht yeah, 2 things

  1. Serve CORS response header with * in JS responses
  2. Insert crossorigin attribute into script tags on document responses (to trigger CORS request). The value can be either anonymous or with-credentials (or whatever that value is). We need to use the latter to be able to support cookie based dev channel opt-in.

cramforce added a commit to cramforce/amphtml that referenced this issue Feb 7, 2017
@cramforce
Directly report errors for browser events and timer.
7c7b347 
Part of ampproject#7353
cramforce added a commit that referenced this issue Feb 7, 2017
@cramforce
Directly report errors for browser events and timer. (#7363)
6a97771 
Part of #7353
torch2424 pushed a commit to torch2424/amphtml that referenced this issue Feb 14, 2017
@cramforce @torch2424
Throttle "Script error." reports. (ampproject#7371)
00b7cbd 
These contain zero information and so we only care about the count, but not about getting every single one.

See ampproject#7353 for context.
torch2424 pushed a commit to torch2424/amphtml that referenced this issue Feb 14, 2017
@cramforce @torch2424
Directly report logged errors instead of relying on rethrowing (amppr…
e1a2943 
…oject#7358)


…and then catching the `error` event.

Part of ampproject#7353
torch2424 pushed a commit to torch2424/amphtml that referenced this issue Feb 14, 2017
@cramforce @torch2424
Directly report errors for browser events and timer. (ampproject#7363)
961e67a 
Part of ampproject#7353
@cramforce cramforce mentioned this issue Feb 15, 2017
Closed
@cramforce
Copy link
Member Author

@dknecht This will be needed for #7566

@cramforce
Copy link
Member Author

Change on Google's JS delivery side rolled out.

@cramforce
Copy link
Member Author

Calling this done

mrjoro pushed a commit to mrjoro/amphtml that referenced this issue Apr 28, 2017
@cramforce @mrjoro
Throttle "Script error." reports. (ampproject#7371)
0f598ce 
These contain zero information and so we only care about the count, but not about getting every single one.

See ampproject#7353 for context.
mrjoro pushed a commit to mrjoro/amphtml that referenced this issue Apr 28, 2017
@cramforce @mrjoro
Directly report logged errors instead of relying on rethrowing (amppr…
54aaed9 
…oject#7358)


…and then catching the `error` event.

Part of ampproject#7353
mrjoro pushed a commit to mrjoro/amphtml that referenced this issue Apr 28, 2017
@cramforce @mrjoro
Directly report errors for browser events and timer. (ampproject#7363)
392ef72 
Part of ampproject#7353
@zhouyx zhouyx mentioned this issue Oct 16, 2019
Closed
@zhouyx zhouyx mentioned this issue Oct 25, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cramforce cramforce

Labels
WG: infra
Projects
None yet
Milestone
New FRs
Development

No branches or pull requests
2 participants
@dknecht @cramforce