-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
V1: allow lightbox to add its own intersection observer to the scheduler #33281
Conversation
8a9809c
to
a88b2e1
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm a confused why this PR only adds to amp-lightbox as opposed to also being able to remove things. Is there no pre-existing functionality this replaces?
I.e.: does unmountAllWithin
also automatically pause all of its subresources? If so we should be able to remove the pause.
It both adds and removes the container for amp-lightbox. Few other elements would quickly follow.
Correct. Unmount also pauses. However, for now, "pause" is still useful in its own right. A little less useful with async pause, but it's still used and maybe would be used in perpetuity. |
14d60c8
to
12a4961
Compare
d140d66
to
ee19595
Compare
When is |
I think all Bento components separate the scroller from the root element to avoid modifying user markup. |
Partial for #31915.
Partial for #31540.
Key changes:
amp-lightbox
can contribute its own intersection observer to the scheduler.unmountAll
is used from the newresources-container-helper.js
.TODO:
resource-container-helper.js
)