Support non-Bento children of Bento elements #33450
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey @jridgewell! These files were changed: |
3 tasks
jridgewell
reviewed
Mar 24, 2021
caroqliu
reviewed
Mar 24, 2021
dvoytenko
force-pushed
the
bento/pause-v0
branch
from
1556efb
to
b632851
Compare
added 2 commits
March 24, 2021 11:37
caroqliu
approved these changes
Mar 24, 2021
jridgewell
approved these changes
Mar 24, 2021
samouri
reviewed
Mar 25, 2021
samouri
reviewed
Mar 25, 2021
| } else { | ||
| // Breadth-first search. Rely on the `getElementsByClassName` DOM order | ||
| // to ignore DOM subtrees already covered. | ||
| seen = seen || []; |
There was a problem hiding this comment.
Copied it from owners-impl.js. But the reason it's not a set is because the test is not seen.contains(target), but seen.some(x => x.contains(target)). The uniqueness of seen itself is guaranteed by the querySelectorAll. Do you think those cases are still improved by using a set?
There was a problem hiding this comment.
No, iterating a Set is considerably slower than iterating an array. Given we must do a some, the Array is the right choice.
There was a problem hiding this comment.
Yeah. That's what I figured as well.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This looks a bit like "owners" code and some of that code was moved. But a big improvement is that this approach no longer requires us to intercept a child's lifecycle - we never need to call
Owners.setOwner()here. As such, the iterators have become simple static utils which I moved to thesrc/utils/resource-container-helper.js.Also, notice that all lifecycle calls I made via
requiresIdleCallbackwhen available.More specific changes are:
slot.js. These are changes are very modest in size.owners-impl.jshas been moved as a set of static utilities into thesrc/utils/resource-container-helper.js.test-owners.jsand added a bunch of new tests.Partial for #30952.