Directly report errors for browser events and timer. #7363
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erwinmombay
approved these changes
Feb 6, 2017
cramforce
force-pushed
the
events-and-timers
branch
from
4b5e5e3
to
44a3465
Compare
cramforce
force-pushed
the
events-and-timers
branch
from
0ab1d68
to
73beb9d
Compare
torch2424
pushed a commit
to torch2424/amphtml
that referenced
this pull request
Feb 14, 2017
jridgewell
added a commit
to jridgewell/amphtml
that referenced
this pull request
Feb 15, 2017
Fixes a bug from ampproject#7363. Because the extensions never see a call to `setReportError`, in their own bundles `reportError` is probably `undefined`. This fix makes `reportError` a global variable, so we get the same requirements (entry-points must call `setReportError`). But now, the extension bundles will use that global `reportError`.
jridgewell
added a commit
to jridgewell/amphtml
that referenced
this pull request
Feb 15, 2017
Fixes a bug from ampproject#7363. Because the extensions never see a call to `setReportError`, in their own bundles `reportError` is probably `undefined`. This fix makes `reportError` a global variable, so we get the same requirements (entry-points must call `setReportError`). But now, the extension bundles will use that global `reportError`.
jridgewell
added a commit
to jridgewell/amphtml
that referenced
this pull request
Feb 16, 2017
Fixes a bug from ampproject#7363. Because the extensions never see a call to `setReportError`, in their own bundles `reportError` is probably `undefined`. This fix makes `reportError` a global variable, so we get the same requirements (entry-points must call `setReportError`). But now, the extension bundles will use that global `reportError`.
jridgewell
added a commit
that referenced
this pull request
Feb 16, 2017
* Fix undefined reportError Fixes a bug from #7363. Because the extensions never see a call to `setReportError`, in their own bundles `reportError` is probably `undefined`. This fix makes `reportError` a global variable, so we get the same requirements (entry-points must call `setReportError`). But now, the extension bundles will use that global `reportError`. * Treat setReportError like initLogConstructor `setReportError` MUST be called from every entry point. * Use simple console logs for 3p frame error reporting Using the standard error reporter requires a tangle of dependencies that are not available to 3p frames. After #5527, we can use `reportError` like normal. * Add comments
jridgewell
added a commit
that referenced
this pull request
Feb 16, 2017
* Fix undefined reportError Fixes a bug from #7363. Because the extensions never see a call to `setReportError`, in their own bundles `reportError` is probably `undefined`. This fix makes `reportError` a global variable, so we get the same requirements (entry-points must call `setReportError`). But now, the extension bundles will use that global `reportError`. * Treat setReportError like initLogConstructor `setReportError` MUST be called from every entry point. * Use simple console logs for 3p frame error reporting Using the standard error reporter requires a tangle of dependencies that are not available to 3p frames. After #5527, we can use `reportError` like normal. * Add comments
mrjoro
pushed a commit
to mrjoro/amphtml
that referenced
this pull request
Apr 28, 2017
mrjoro
pushed a commit
to mrjoro/amphtml
that referenced
this pull request
Apr 28, 2017
* Fix undefined reportError Fixes a bug from ampproject#7363. Because the extensions never see a call to `setReportError`, in their own bundles `reportError` is probably `undefined`. This fix makes `reportError` a global variable, so we get the same requirements (entry-points must call `setReportError`). But now, the extension bundles will use that global `reportError`. * Treat setReportError like initLogConstructor `setReportError` MUST be called from every entry point. * Use simple console logs for 3p frame error reporting Using the standard error reporter requires a tangle of dependencies that are not available to 3p frames. After ampproject#5527, we can use `reportError` like normal. * Add comments
This was referenced Apr 22, 2020
This was referenced May 7, 2020
This was referenced Dec 20, 2020
This was referenced May 24, 2021
This was referenced Oct 11, 2021
This was referenced Nov 3, 2021
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #7353