Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Grid pinning and last row #6528

Closed
jschuler opened this issue Jan 8, 2018 · 1 comment · Fixed by #6612
Closed

Grid pinning and last row #6528

jschuler opened this issue Jan 8, 2018 · 1 comment · Fixed by #6612

Comments

@jschuler
Copy link

jschuler commented Jan 8, 2018

When pinning some columns, I am seeing an issue where the last row is partially cut off when the browser is wide enough where a horizontal scrollbar is not needed.

Reproduced with the plunkr linked from the pinning tutorial:
http://ui-grid.info/docs/#!/tutorial/203_pinning

Working fine as there is a horizontal scrollbar and last row can be fully seen:
image

Making browser wider so that there is no horizontal scrollbar:
image
@andrewkittredge
Copy link
Contributor

Related to #6292

DanielDiTommaso pushed a commit to DanielDiTommaso/ui-grid that referenced this issue Mar 19, 2018
fix(GridRenderContainer.js): needsHScrollbarPlaceholder accounts for …
52ce405 
…WHEN_NEEDED

Added logic to needsHScrollbarPlaceholder to account for left/right rendercontainers as well as
handle case when gridOption enableHorizontalScrollbar is set to WHEN_NEEDED.

fix angular-ui#6280, fix angular-ui#5812, fix angular-ui#5760, fix angular-ui#6590, fix angular-ui#6572, fix angular-ui#6528, fix angular-ui#4251, fix angular-ui#3022
@DanielDiTommaso DanielDiTommaso mentioned this issue Mar 19, 2018
Merged
mportuga pushed a commit that referenced this issue Mar 19, 2018
@mportuga
fix(GridRenderContainer.js): needsHScrollbarPlaceholder accounts for …
403bf3e 
…WHEN_NEEDED

Added logic to needsHScrollbarPlaceholder to account for left/right rendercontainers as well as
handle case when gridOption enableHorizontalScrollbar is set to WHEN_NEEDED.

fix #6280, fix #5812, fix #5760, fix #6590, fix #6572, fix #6528, fix #4251, fix #3022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(WHEN_NEEDED): needsHScrollbarPlaceholder accounts for WHEN_NEEDED DanielDiTommaso/ui-grid
2 participants
@andrewkittredge @jschuler