Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pinning and Auto-Resize render issue #6590

Closed
sfebish opened this issue Mar 6, 2018 · 1 comment · Fixed by #6612
Closed

Pinning and Auto-Resize render issue #6590

sfebish opened this issue Mar 6, 2018 · 1 comment · Fixed by #6612
Labels
type: enhancement

Comments

@sfebish
Copy link

sfebish commented Mar 6, 2018

With the combination of pinned columns and auto-resize, it seems that the grid is always leaving a spacer (.ui-grid-scrollbar-placeholder) even when there is no scrollbar.

Using example, if you hide enough columns to get rid of the horizontal scroll you can reproduce the behavior.

With scrollbar visible:
withscrollbar

Without scrollbar visible:
withoutscrollbar

The base of the pinned columns should be the same as the base of the unpinned columns.

I can reproduce this in both I.E and Firefox.
@mportuga
Copy link
Member

I believe this will be solved by reintroducing the WHEN_NEEDED attribute for scrollbars:
http://ui-grid.info/docs/#!/api/ui.grid.service:uiGridConstants
https://github.com/angular-ui/ui-grid/blob/master/src/js/core/factories/GridRenderContainer.js#L770
https://github.com/angular-ui/ui-grid/blob/master/src/templates/ui-grid/uiGridRenderContainer.html#L9

DanielDiTommaso pushed a commit to DanielDiTommaso/ui-grid that referenced this issue Mar 19, 2018
fix(GridRenderContainer.js): needsHScrollbarPlaceholder accounts for …
52ce405 
…WHEN_NEEDED

Added logic to needsHScrollbarPlaceholder to account for left/right rendercontainers as well as
handle case when gridOption enableHorizontalScrollbar is set to WHEN_NEEDED.

fix angular-ui#6280, fix angular-ui#5812, fix angular-ui#5760, fix angular-ui#6590, fix angular-ui#6572, fix angular-ui#6528, fix angular-ui#4251, fix angular-ui#3022
@DanielDiTommaso DanielDiTommaso mentioned this issue Mar 19, 2018
Merged
mportuga pushed a commit that referenced this issue Mar 19, 2018
@mportuga
fix(GridRenderContainer.js): needsHScrollbarPlaceholder accounts for …
403bf3e 
…WHEN_NEEDED

Added logic to needsHScrollbarPlaceholder to account for left/right rendercontainers as well as
handle case when gridOption enableHorizontalScrollbar is set to WHEN_NEEDED.

fix #6280, fix #5812, fix #5760, fix #6590, fix #6572, fix #6528, fix #4251, fix #3022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type: enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(WHEN_NEEDED): needsHScrollbarPlaceholder accounts for WHEN_NEEDED DanielDiTommaso/ui-grid
2 participants
@mportuga @sfebish