-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Slash is not removed for squash:true when optional param terminates the url #1902
Comments
+1 |
I think what you're seeing is correct behavior. According to the docs, only one of two slashes is omitted. |
Is it hard to make a setting to clean/trim the end of the URL with squashed params? It's frustrating when all your URLs are consistent with no trailing slash and then you hit one url with a trailing slash because it has a squashed parameter. |
@christopherthielen in my reprod steps, none are removed: false: '/user/christopherthielen',
// …
true: '/user/' the slash preceding |
bump. Is anyone looking into this? If not, could someone point me to where this is in the code base and I'll take a stab at it. |
@jshado1 :Hi, How to handle this issue ? i'm facing this issue right now in my development. how to remove trailing slashes in ui-sref using squash! |
In @christopherthielen's plunkr example from #1501,
:username
's slash is not removed when it is squashed. The documented behaviour forsquash: true
is that the optional parameter plus a slash are removed.Reprod:
user({username: 'christopherthielen'})
button.Observed output:
/user/
Expect output:
/user
The text was updated successfully, but these errors were encountered: