fix(UrlMatcherFactory): Correct trailing slash of terminal optional parameter

[JakobJingleheimer]

Fixes #1902

[christopherthielen]

Thanks jshado1

Does this perform symmetrically, i.e., does it also match properly when the trailing slashes are omitted?
Also, I don't think this obeys the $urlMatcherFactory.strictMode setting.

Can you address those issues and push an updated PR?

I'd like to see additional unit tests for more combinations, with the above questions in mind accounting for:

• optional and non-optional
• strictMode setting
• URL generation symmetric with matching

[JakobJingleheimer]

this should probably be changed to i + 1 === nPath (isPathParam already ensures that this is within nPath).

[JakobJingleheimer]

Hi @christopherthielen,

I think there're other tests that (inadvertently?) assert cases 1 and 2. I'll look for them.

Is it safe to assume that param.squash will inherit defaultSquashPolicy when it hasn't been explicitly set?

Thanks for the feedback.

[nateabele]

Also, I don't think this obeys the $urlMatcherFactory.strictMode setting.

That should really only apply to parsing.

Is it safe to assume that param.squash will inherit defaultSquashPolicy when it hasn't been explicitly set?

https://github.com/jshado1/ui-router/blob/1902/src/urlMatcherFactory.js#L202

@jshado1 If you wanna make the change you noted above and squash your commits, this is 👍 from me.

Thanks for your work on this!

[JakobJingleheimer]

@christopherthielen, non-optional is covered by urlMatcherFactorySpec.js#L617.

Does this perform symmetrically, i.e., does it also match properly when the trailing slashes are omitted?

Possibly lacking caffeine, but what is "it" ?

@nateabele will do when i get home tonight.

[JakobJingleheimer]

@nateabele I made that change I had commented on (and squashed).

[christopherthielen]

Regarding my symmetry comment, I want to make sure that if strict mode is on and a url is generated (with trailing slash removed), that the url will then be matched correctly to the same state and paeans (for instance if the user hits reload in the browser)