Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support adding CSS class to MdDialog root element #4012

Closed
xtianus79 opened this issue Apr 10, 2017 · 5 comments
Closed

Support adding CSS class to MdDialog root element #4012

xtianus79 opened this issue Apr 10, 2017 · 5 comments
Labels
feature This issue represents a new feature or feature request rather than a bug or bug fix needs: discussion Further discussion with the team is needed before proceeding

Comments

@xtianus79
Copy link

Bug, feature request, or proposal:

Bug / Feature

What is the expected behavior?

Unlike The toast notifications which has a parameter to add a class... There is nothing I can add on the parent container level to change styling of md dialog.

What is the current behavior?

I can just override material styles

Which versions of Angular, Material, OS, browsers are affected?

2.0.0-beta.2

Is there anything else we should know?

Nope
@xtianus79 xtianus79 changed the title I cannot access MdDialog so that I have am able to assign a Class or something to differentiate styling between modals Unable to access MdDialog so that I have am able to assign a Class or something to differentiate styling between modals Apr 10, 2017
@fxck
Copy link
Contributor

fxck commented Apr 10, 2017

#3472

@jelbourn jelbourn changed the title Unable to access MdDialog so that I have am able to assign a Class or something to differentiate styling between modals Support adding CSS class to MdDialog root element Apr 11, 2017
@jelbourn jelbourn added discussion feature This issue represents a new feature or feature request rather than a bug or bug fix labels Apr 11, 2017
@xtianus79
Copy link
Author

xtianus79 commented Apr 22, 2017 •
edited
Loading

@fxck and @jelbourn as of right now this is not available? Or it is on beta.3

@donroyco donroyco mentioned this issue May 22, 2017
Closed
jbojcic1 added a commit to jbojcic1/material2 that referenced this issue May 22, 2017
@jbojcic1
feat(dialog): custom class option
07442eb 
Extend dialog config options to allow custom dialog class. Custom class enables media queries.

angular#4718 angular#4012
jbojcic1 added a commit to jbojcic1/material2 that referenced this issue May 22, 2017
@jbojcic1
feat(dialog): custom class option
5eec0ff 
Extend dialog config options to allow custom dialog class. Custom class enables media queries.

angular#4718 angular#4012
jbojcic1 added a commit to jbojcic1/material2 that referenced this issue May 24, 2017
@jbojcic1
refactor(dialog): custom class option.
9832cad 
Changed custom class config option name. Remove unnecessary class removal on detach.

angular#4718 angular#4012
jbojcic1 added a commit to jbojcic1/material2 that referenced this issue May 24, 2017
@jbojcic1
test(dialog): custom class option.
5944616 
Added missing unit test to check if overlay pane has custom panel class.

angular#4718 angular#4012
jbojcic1 added a commit to jbojcic1/material2 that referenced this issue May 24, 2017
@jbojcic1
refactor(dialog): custom class option.
f456794 
Change wrong comment. Remove unnecessary beforeEach from test.

angular#4718 angular#4012
mmalerba pushed a commit that referenced this issue May 30, 2017
@jbojcic1 @mmalerba
feat(dialog): custom class option #4718 #4012 (#4722)
28c936f 
* feat(dialog): custom class option

Extend dialog config options to allow custom dialog class. Custom class enables media queries.

#4718 #4012

* refactor(dialog): custom class option.

Changed custom class config option name. Remove unnecessary class removal on detach.

#4718 #4012

* test(dialog): custom class option.

Added missing unit test to check if overlay pane has custom panel class.

#4718 #4012

* refactor(dialog): custom class option.

Change wrong comment. Remove unnecessary beforeEach from test.

#4718 #4012
@jelbourn
Copy link
Member

This exists now

@shizhenbin
Copy link

like this is okay:
this.MarketOrderDetailComponent = this.dialog.open(MarketOrderDetailComponent,{height: '100%',width: '100%',panelClass:"detailDialog"});

@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 7, 2019
@mmalerba mmalerba added the needs: discussion Further discussion with the team is needed before proceeding label Mar 3, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
feature This issue represents a new feature or feature request rather than a bug or bug fix needs: discussion Further discussion with the team is needed before proceeding
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@jelbourn @fxck @xtianus79 @mmalerba @shizhenbin