feat(overlay): add ability to set custom class on panes

[fxck]

I re-did #1438

It includes tests for overlay(I didn't see any similar tests for say backdrop class on menu or dialog, so I assumed it's not required since it should inherently work when overlay tests passes) and comments from the previous PR with the exception of #1438 (comment) and #1438 (comment) which didn't make sense to me.

@jelbourn

[jelbourn]

@fxck Would your specific problem be solved by simply having a higher z-index on the overlay container? (right now it's just 1 to create a new stacking context).

[fxck]

No, unless I were in control of that z-index. But what might be worth doing is sticking that custom class on container rather than pane. I'm not sure what was the original reasoning for putting it on panes, it's been a while.

I guess having the class on the container rather than on pane would make sense. You wouldn't have to use /deep/ to actually target the pane.. I think anyway.

So how about this:

1. I'll move the custom class to the container rather than the pane

2. I'll change the default z-index of container to 1000, because of this http://jsbin.com/mesujat/1/edit?html,css,output (z-index 1000 on pane has absolutely no effect because the container has z-index 1)

3. I'll change the default z-index of pane and backdrop to 2(pane) and 1(backdrop), and I'll hardcode it, because of the above point, having this configurable doesn't have any sense, since the only behaviour you need inside the container is that pane is above backdrop

@jelbourn

[fxck]

I see, the reason why I added it to pane instead of container was that there is only one container.

Then there's this ..

..when you open, menu from inside a dialog, the stacking order is not correct, dialog itself it above menu's backdrop.

I think is issue is a bit deeper, there should be some sort of stacking order manager.

@jelbourn @kara

[crisbeto]

Are there any plans to continue with this PR? Something similar (being able to add a class to the .overlay-pane) should help with an issue where the tooltip can sometimes become hidden immediately.

[fxck]

I never got the reply about stacking manager. I think adding classes to either pane or overlay would be only a temporary fix and more issues will come up sooner or later. But I don't want to do anything without having a discussion.

[jelbourn]

This has been on the backburner since I've been wanting to spend some more time thinking about how stacking should work in general.

[fxck]

Stacking aside, this still could be useful, currently there's no way to properly style md-menu(stuff like width).

[fxck]

I take it back, there is, it has to be global though.

[mmalerba]

@jelbourn @fxck what's the status of this should it be rebased? closed?

[fxck]

for what it was, this PR is obsolete, altho most of my points stands, there still are cases when inability to control z-index of panes and overlays still can cause problems, as well as I think there needs to be a class that handles z-index of various elements.

[mmalerba]

@fxck ok will close this PR then, if you have concerns about z-index that aren't already being tracked by an issue, feel free to open a new issue to discuss them.

[angular-automatic-lock-bot]

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

_{This action has been performed automatically by a bot.}