Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update tslint to latest version #2952

Merged
merged 2 commits into from
Feb 9, 2017

Conversation

devversion
Copy link
Member

@devversion devversion commented Feb 6, 2017

Note: I wrote a TSLint modification that fixes all warnings for no-inferrable-types, but since Dgeni explicitly needs types the changes are obsolete (See here)

Note: This change is mostly in favor of #2175 because we want to have our own custom TSLint rules instead of having the forbidden-identifiers script.

References #2175

* Updates TSLint to the latest version.
* Due to some breaking changes we had to temporary disable the `no-inferrable-types` rule. Need to revisit once palantir/tslint#2158 is addressed.

References angular#2175
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Feb 6, 2017
@devversion
Copy link
Member Author

Made some changes that I discussed with @crisbeto.

Copy link
Member

@crisbeto crisbeto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@devversion devversion added the action: merge The PR is ready for merge by the caretaker label Feb 7, 2017
@tinayuangao tinayuangao merged commit 902edd0 into angular:master Feb 9, 2017
@devversion devversion deleted the chore/update-tslint branch February 9, 2017 18:34
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 6, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants