Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update tslint to latest version #2952

Merged
merged 2 commits into from
Feb 9, 2017
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -94,7 +94,8 @@
"stylelint": "^7.7.1",
"travis-after-modes": "0.0.7",
"ts-node": "^2.0.0",
"tslint": "^3.13.0",
"tslint": "^4.4.2",
"tslint-no-unused-var": "0.0.6",
"typescript": "~2.0.10",
"uglify-js": "^2.7.5",
"web-animations-js": "^2.2.2"
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ export type ElementBoundingPositions = {
right: number;
bottom: number;
left: number;
}
};

/**
* A strategy for positioning overlays. Using this strategy, an overlay is given an
Expand Down
2 changes: 1 addition & 1 deletion src/lib/progress-spinner/progress-spinner.ts
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ const MAX_ANGLE = 359.99 / 100;
export type ProgressSpinnerMode = 'determinate' | 'indeterminate';

type EasingFn = (currentTime: number, startValue: number,
changeInValue: number, duration: number) => number
changeInValue: number, duration: number) => number;


/**
Expand Down
4 changes: 2 additions & 2 deletions src/lib/tooltip/tooltip.ts
Original file line number Diff line number Diff line change
Expand Up @@ -331,7 +331,7 @@ export class TooltipComponent {
// trigger interaction and close the tooltip right after it was displayed.
this._closeOnInteraction = false;

// Mark for check so if any parent component has set the
// Mark for check so if any parent component has set the
// ChangeDetectionStrategy to OnPush it will be checked anyways
this._changeDetectorRef.markForCheck();
setTimeout(() => { this._closeOnInteraction = true; }, 0);
Expand All @@ -352,7 +352,7 @@ export class TooltipComponent {
this._visibility = 'hidden';
this._closeOnInteraction = false;

// Mark for check so if any parent component has set the
// Mark for check so if any parent component has set the
// ChangeDetectionStrategy to OnPush it will be checked anyways
this._changeDetectorRef.markForCheck();
}, delay);
Expand Down
8 changes: 6 additions & 2 deletions tslint.json
Original file line number Diff line number Diff line change
@@ -1,7 +1,11 @@
{
"rulesDirectory": ["node_modules/tslint-no-unused-var"],
"rules": {
"max-line-length": [true, 100],
"no-inferrable-types": true,
// Disable this flag because of SHA tslint#48b0c597f9257712c7d1f04b55ed0aa60e333f6a
// TSLint now shows warnings if types for properties are inferred. This rule needs to be
// disabled because all properties need to have explicit types set to work for Dgeni.
"no-inferrable-types": false,
"class-name": true,
"comment-format": [
true,
Expand All @@ -20,7 +24,7 @@
"no-bitwise": true,
"no-shadowed-variable": true,
"no-unused-expression": true,
"no-unused-variable": [true, {"ignore-pattern": "^(_.*)$"}],
"no-unused-var": [true, {"ignore-pattern": "^(_.*)$"}],
"one-line": [
true,
"check-catch",
Expand Down