Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fxLayoutGap not working with fxLayout fxFlexOrder #697

Closed
parindholakia opened this issue Apr 5, 2018 · 9 comments · Fixed by #927
Closed

fxLayoutGap not working with fxLayout fxFlexOrder #697

parindholakia opened this issue Apr 5, 2018 · 9 comments · Fixed by #927
Assignees
Labels
bug has pr A PR has been created to address this issue P0 Critical issue that needs to be resolved immediately
Milestone

Comments

@parindholakia
Copy link

parindholakia commented Apr 5, 2018

Bug:

fxLayoutGap does not work when fxFlexOrder is given with responsive breakpoints.Initially it is rendered properly. But when the screen is resized,fxLayoutGap does not work.

What is the expected behavior?

fxLayoutGap should work when screen is resized.

What are the steps to reproduce?

stackblitz

  1. Initial Page rendered.

image

  1. After page resize
    image

  2. normal mode after resizing.

image

@CaerusKaru
Copy link
Member

Related to #606, I have some fixes in mind that we'll try to get in by beta.16

@CaerusKaru CaerusKaru added bug P1 Urgent issue that should be resolved before the next re-lease labels Apr 5, 2018
@CaerusKaru CaerusKaru self-assigned this Apr 5, 2018
@CaerusKaru CaerusKaru added this to the v6.0.0-beta.16 milestone Apr 5, 2018
@m-henderson
Copy link

@CaerusKaru do you need help with this issue? if so, could you give me a starting point?

@CaerusKaru
Copy link
Member

@m-henderson If you want to pitch in, that'd be great! The starting point most likely involves adding a MutationObserver in the LayoutGapDirective that watches all immediate children for changes, particularly relating to ordering (essentially re-running the initialization logic).

@CaerusKaru
Copy link
Member

Let's revisit this once #900 lands. @parindholakia would you be willing to test it out on the new version?

@CaerusKaru
Copy link
Member

This is half-working after 7.0.0-beta.21. The gap now works after resizes, but only in row mode, not column mode. And now there's a new bug with fxFlexOrder, where it doesn't disengage afterwards (which is an easy fix).

@CaerusKaru CaerusKaru added P0 Critical issue that needs to be resolved immediately and removed P1 Urgent issue that should be resolved before the next re-lease labels Dec 15, 2018
@CaerusKaru
Copy link
Member

CaerusKaru commented Dec 15, 2018

Encapsulated the fxFlexOrder responsive issues here: #918. Will start working on a fix, followed by the layout-gap issues. The root cause has been tracked and will be pushed shortly.

@CaerusKaru
Copy link
Member

CaerusKaru commented Dec 15, 2018

And here's the tracking PR for the layout-gap issues: #919. The root cause has been tracked and will be pushed shortly.

@CaerusKaru
Copy link
Member

I've tested the StackBlitz against the latest nightly build, and confirmed that this issue is fixed. To see for yourself, update all deps to latest, and then install https://github.com/angular/flex-layout-builds#master-d322ea7.

@CaerusKaru CaerusKaru unpinned this issue Dec 19, 2018
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 5, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug has pr A PR has been created to address this issue P0 Critical issue that needs to be resolved immediately
Projects
None yet
3 participants