Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(core): clear recent styles after responsive deactivation #926

Closed
wants to merge 4 commits into from
Closed

fix(core): clear recent styles after responsive deactivation #926

wants to merge 4 commits into from

Conversation

ThomasBurleson
Copy link
Contributor

Fixes #697
Fixes #296

@googlebot
Copy link
Collaborator

So there's good news and bad news.

👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there.

😕 The bad news is that it appears that one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that here in the pull request.

Note to project maintainer: This is a terminal state, meaning the cla/google commit status will not change from this state. It's up to you to confirm consent of all the commit author(s), set the cla label to yes (if enabled on your project), and then merge this pull request when appropriate.

@googlebot googlebot added the cla: no PR author needs to sign Google's CLA: https://opensource.google.com/docs/cla/ label Dec 16, 2018
@ThomasBurleson ThomasBurleson mentioned this pull request Dec 16, 2018
Closed
@CaerusKaru
Copy link
Member

Closed in favor of #927. Like musical chairs but with PRs

@CaerusKaru CaerusKaru closed this Dec 16, 2018
@CaerusKaru CaerusKaru deleted the pr/918 branch December 16, 2018 16:35
CaerusKaru
CaerusKaru reviewed Dec 16, 2018
View reviewed changes
src/lib/core/media-marshaller/media-marshaller.ts
@@ -47,8 +53,10 @@ export class MediaMarshaller {

constructor(protected matchMedia: MatchMedia,
protected breakpoints: BreakPointRegistry) {
this.matchMedia.observe().subscribe(this.activate.bind(this));
this.registerBreakpoints();
this.registerBreakpoints(); // register first!
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

register first!

This was the entire point of #923

src/lib/core/base/base2.ts
@@ -15,9 +15,14 @@ import {buildLayoutCSS} from '../../utils/layout-validator';

export abstract class BaseDirective2 implements OnChanges, OnDestroy {

private destroySubject: Subject<void> = new Subject();
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We discussed that we wouldn't do this because it adds complexity with very little benefit

@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 6, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@CaerusKaru CaerusKaru CaerusKaru left review comments

Assignees
No one assigned
Labels
cla: no PR author needs to sign Google's CLA: https://opensource.google.com/docs/cla/
Projects
None yet
Milestone
No milestone
3 participants
@ThomasBurleson @googlebot @CaerusKaru