Skip to content
This repository has been archived by the owner on Sep 5, 2024. It is now read-only.

checkbox: should fire click event on submit button if one exists #11639

Closed
Splaktar opened this issue Feb 15, 2019 · 0 comments · Fixed by #11640
Closed

checkbox: should fire click event on submit button if one exists #11639

Splaktar opened this issue Feb 15, 2019 · 0 comments · Fixed by #11640
Assignees
Labels
a11y This issue is related to accessibility g3: reported The issue was reported by an internal or external product team. has: Pull Request A PR has been created to address this issue P1: urgent Urgent issues that should be addressed in the next minor or patch release. resolution: fixed severity: regression This issue is related to a regression type: bug
Milestone

Comments

@Splaktar
Copy link
Member

Splaktar commented Feb 15, 2019

Bug

CodePen and steps to reproduce the issue:

CodePen Demo which demonstrates the issue: https://codepen.io/Splaktar/pen/VgVZRJ?editors=1010#0

Detailed Reproduction Steps:

  1. Focus the native checkbox
  2. Press enter and verify that the form was not submitted (validation text doesn't display)
  3. Focus the md-checkbox
  4. Press enter and see that the form was submitted (validation text displays)

Examples of the native behavior

What is the expected behavior?

When the ENTER key is pressed, checkbox should search the form for all submit buttons and inputs and send a MouseClick event to the first submit button that is not disabled.

Verify that this CodePen still works.

What is the current behavior?

Checkbox emits a native submit event when the ENTER key is pressed.

What is the use-case or motivation for changing an existing behavior?

Checkbox keyboard behavior should match the native behavior on Chrome.

Which versions of AngularJS, Material, OS, and browsers are affected?

  • AngularJS: 1.7.6
  • AngularJS Material: 1.1.13
  • OS: macOS
  • Browsers: Chrome

Is there anything else we should know? Stack Traces, Screenshots, etc.

@codymikol heads up that this is related to PR #11584 and issue #11583. I will try to make a fix for this today.

@Splaktar Splaktar added the P1: urgent Urgent issues that should be addressed in the next minor or patch release. label Feb 15, 2019
@Splaktar Splaktar added this to the 1.1.13 milestone Feb 15, 2019
@Splaktar Splaktar self-assigned this Feb 15, 2019
@Splaktar Splaktar added type: bug a11y This issue is related to accessibility g3: reported The issue was reported by an internal or external product team. labels Feb 15, 2019
Splaktar added a commit that referenced this issue Feb 15, 2019
match the behavior of the native input type checkbox

Fixes #11639
Splaktar added a commit that referenced this issue Feb 15, 2019
match the behavior of the native input type checkbox

Fixes #11639
Splaktar added a commit that referenced this issue Feb 15, 2019
match the behavior of the native input type checkbox

Fixes #11639
@Splaktar Splaktar added severity: regression This issue is related to a regression has: Pull Request A PR has been created to address this issue labels Feb 15, 2019
Splaktar added a commit that referenced this issue Feb 16, 2019
match the behavior of the native input type checkbox

Fixes #11639
Splaktar added a commit that referenced this issue Feb 19, 2019
match the behavior of the native input type checkbox

Fixes #11639
Splaktar added a commit that referenced this issue Feb 19, 2019
match the behavior of the native input type checkbox

Fixes #11639
Splaktar added a commit that referenced this issue Feb 19, 2019
match the behavior of the native input type checkbox

Fixes #11639
jelbourn pushed a commit that referenced this issue Feb 21, 2019
)

match the behavior of the native input type checkbox

Fixes #11639
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
a11y This issue is related to accessibility g3: reported The issue was reported by an internal or external product team. has: Pull Request A PR has been created to address this issue P1: urgent Urgent issues that should be addressed in the next minor or patch release. resolution: fixed severity: regression This issue is related to a regression type: bug
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant