This repository has been archived by the owner on Sep 5, 2024. It is now read-only.
fix(checkbox): submit on enter rather than toggle #11584
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
Splaktar
added
a11y
Splaktar
suggested changes
Jan 9, 2019
Splaktar
added
the
in progress
make enter keypress submit form rather than toggle checkbox Fixes: angular#11583
codymikol
force-pushed
the
fix-checkbox-enter
branch
from
24df4a8
to
1944cbe
Compare
Splaktar
added
pr: merge ready
Splaktar
added a commit
that referenced
this pull request
Feb 1, 2019
3 tasks
mmalerba
pushed a commit
that referenced
this pull request
Feb 1, 2019
Splaktar
reviewed
Feb 15, 2019
| var form = $mdUtil.getClosest(ev.target, 'form'); | ||
| // We have to use a native event here as the form directive does not use jqlite | ||
| if (form) { | ||
| form.dispatchEvent(new Event('submit')); |
There was a problem hiding this comment.
It looks like this can possibly submit the form even when the button of type="submit" is disabled.
There was a problem hiding this comment.
This seems to align with the native behavior where pressing enter in an input will submit the form even if the form has no button.
There was a problem hiding this comment.
More investigation and follow up in #11639.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
make enter keypress submit form rather than toggle checkbox
Fixes: #11583
PR Checklist
Please check that your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Currently if you have a checkbox focused and press enter, you toggle the value of the checkbox.
Issue Number: #11583
What is the new behavior?
Now pressing enter while focusing a checkbox within a form, the form will be submitted. If no form exists, nothing will happen.
Does this PR introduce a breaking change?
Other information
N/A