fix(slider): support for RTL and invert #1794
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
mmalerba
force-pushed
the
slider-spec
branch
3 times, most recently
from
97fe5d4
to
fa6bbcc
Compare
mmalerba
force-pushed
the
slider-spec
branch
from
fa6bbcc
to
dc5be93
Compare
jelbourn
reviewed
Nov 12, 2016
| @@ -66,6 +75,11 @@ md-slider { | |||
| overflow: hidden; | |||
| } | |||
|
|
|||
| [dir='rtl'] .md-slider-ticks-container { | |||
| // translateZ(0) prevents chrome bug where overflow: hidden; doesn't work. | |||
There was a problem hiding this comment.
Do you have a link to the Chrome bug?
There was a problem hiding this comment.
I don't, I would file one except its really elusive. If a try replicating this HTML/CSS in a jsfiddle it doesn't happen.
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
blocked on #1759