Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/FSRS progress sometime shows 0 reviews #3591

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

L-M-Sherlock
Copy link
Contributor

@L-M-Sherlock L-M-Sherlock commented Nov 19, 2024

source: https://forums.ankiweb.net/t/anki-24-10-beta/49989/223?u=l.m.sherlock

If the optimization is done in 100ms, the thread cannot update the progress before the function return the results.

#3420 cannot deal with this case.

@dae
Copy link
Member

dae commented Nov 19, 2024

Appreciate the fix as always :-) But blocking the main thread like that is not ideal, nor is adding 100ms even when not necessary. @abdnh, can you think of a better approach?

@L-M-Sherlock
Copy link
Contributor Author

I think it's better than my previous idea.

progress_thread.join().ok();

But it still blocks the main thread.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants