Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix/FSRS progress sometime shows 0 reviews #3591

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
+2 −1
Open

Fix/FSRS progress sometime shows 0 reviews #3591

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
37769b0
Fix/FSRS progress sometime shows 0 reviews
L-M-Sherlock Nov 19, 2024
9dbd1d1
Merge branch 'main' into Fix/FSRS-progress-sometime-shows-0-reviews
L-M-Sherlock Nov 19, 2024
fc8c057
wait for progress_thread
L-M-Sherlock Nov 19, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion rslib/src/scheduler/fsrs/params.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,7 +81,7 @@ impl Collection {
// adapt the progress handler to our built-in progress handling
let progress = CombinedProgressState::new_shared();
let progress2 = progress.clone();
thread::spawn(move || {
let progress_thread = thread::spawn(move || {
let mut finished = false;
while !finished {
thread::sleep(Duration::from_millis(100));
Expand All @@ -98,6 +98,7 @@ impl Collection {
}
});
let mut params = FSRS::new(None)?.compute_parameters(items.clone(), Some(progress2))?;
progress_thread.join().ok();
if let Ok(fsrs) = FSRS::new(Some(current_params)) {
let current_rmse = fsrs.evaluate(items.clone(), |_| true)?.rmse_bins;
let optimized_fsrs = FSRS::new(Some(&params))?;
Expand Down