-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updates based on recent changes and discussion on RFC PR #262 #5
Conversation
* Added the Implementation Conventions and Usage Overview section. * Replaced the Stability / User Impact with the Versioning Strategy and Stability section. Also moved the section higher. * Updated the API design according to the real implementation. * Updated code examples.
…gableDevice RFC (PR tensorflow#262). * Referenced semver and TensorFlow's Version Compatibility page. * Added the Updating Guidelines, Convention, and Detecting Incompatibility sections. * Merged the current code examples with @yisitu's newer ones on PR tensorflow#262 and simplified them a bit.
@yisitu Could you please help review as well? (I can't tag you as a reviewer.) Thank you very much! |
rfcs/20200612-stream-executor-c-api/C_API_versioning_strategy.md
Outdated
Show resolved
Hide resolved
rfcs/20200612-stream-executor-c-api/C_API_versioning_strategy.md
Outdated
Show resolved
Hide resolved
Also some more minor edits.
Co-authored-by: Situ Yi <[email protected]>
rfcs/20200612-stream-executor-c-api/C_API_versioning_strategy.md
Outdated
Show resolved
Hide resolved
rfcs/20200612-stream-executor-c-api/C_API_versioning_strategy.md
Outdated
Show resolved
Hide resolved
rfcs/20200612-stream-executor-c-api/C_API_versioning_strategy.md
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've done a round of review, please have a look. Thanks for consolidating the Github comments and polishing up the document Penporn!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the thorough review! :D
rfcs/20200612-stream-executor-c-api/C_API_versioning_strategy.md
Outdated
Show resolved
Hide resolved
Co-authored-by: Situ Yi <[email protected]>
Changed "shall" to "must" to make sure people would not misinterpret "shall".
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Changes to the Main RFC File
Changes to the Versioning Strategy File:
Added/updated contents based on the discussion on the PluggableDevice RFC.
Specifically, addressed the following points in the comments on the PluggableDevice RFC: