Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updates based on recent changes and discussion on RFC PR #262 #5

Merged
merged 8 commits into from
Sep 10, 2020
Merged

Updates based on recent changes and discussion on RFC PR #262 #5

merged 8 commits into from
Sep 10, 2020

Commits on Sep 3, 2020

  1. Merge remote-tracking branch 'annarev/stream_executor_rfc'

    @penpornk
    penpornk committed Sep 3, 2020
    Configuration menu
    Copy the full SHA
    2255854 View commit details
    Browse the repository at this point in the history

Commits on Sep 9, 2020

  1. Update 20200612-stream-executor-c-api.md 

    * Added the Implementation Conventions and Usage Overview section.
* Replaced the Stability / User Impact with the Versioning Strategy and Stability section. Also moved the section higher.
* Updated the API design according to the real implementation.
* Updated code examples.
    @penpornk
    penpornk authored Sep 9, 2020
    Configuration menu
    Copy the full SHA
    3bb5b4d View commit details
    Browse the repository at this point in the history

  2. Added/updated versioning contents based on the discussion on the Plug… 

    …gableDevice RFC (PR tensorflow#262).

* Referenced semver and TensorFlow's Version Compatibility page.
* Added the Updating Guidelines, Convention, and Detecting Incompatibility sections.
* Merged the current code examples with @yisitu's newer ones on PR tensorflow#262 and simplified them a bit.
    @penpornk
    penpornk authored Sep 9, 2020
    Configuration menu
    Copy the full SHA
    9787cb1 View commit details
    Browse the repository at this point in the history

  3. Merge remote-tracking branch 'annarev/stream_executor_rfc'

    @penpornk
    penpornk committed Sep 9, 2020
    Configuration menu
    Copy the full SHA
    b3360a8 View commit details
    Browse the repository at this point in the history

  4. Fixes according to annarev@'s comments. 

    Also some more minor edits.
    @penpornk
    penpornk authored Sep 9, 2020
    Configuration menu
    Copy the full SHA
    d1ec351 View commit details
    Browse the repository at this point in the history

Commits on Sep 10, 2020

  1. Apply suggestions from code review 

    Co-authored-by: Situ Yi <[email protected]>
    @penpornk @yisitu
    penpornk and yisitu authored Sep 10, 2020
    Configuration menu
    Copy the full SHA
    1a6f2cf View commit details
    Browse the repository at this point in the history

  2. Apply suggestions from code review 

    Co-authored-by: Situ Yi <[email protected]>
    @penpornk @yisitu
    penpornk and yisitu authored Sep 10, 2020
    Configuration menu
    Copy the full SHA
    0218043 View commit details
    Browse the repository at this point in the history

  3. More clean-ups. 

    Changed "shall" to "must" to make sure people would not misinterpret "shall".
    @penpornk
    penpornk authored Sep 10, 2020
    Configuration menu
    Copy the full SHA
    cc0f721 View commit details
    Browse the repository at this point in the history