[PR #1174/9401932f backport][stable-5] Refacterization of code to use 'fallback' instead of using os.environ #1224
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![patchback[bot]](https://avatars.githubusercontent.com/in/21488?s=60&v=4){kind=small}
…#1174) Refacterization of code to use 'fallback' instead of using os.environ SUMMARY When the "ec2" module was first added, it included support for pulling credentials out of the environment variables. 3.5 years later, in Ansible 2.1, support for configuring a 'fallback' directly in the argument specification was added, but we never got around to using it. This PR finally cleans up the code and lets the argument parser directly handle fallback to environment variables. ISSUE TYPE Feature Pull Request COMPONENT NAME plugins/module_utils/botocore.py plugins/module_utils/modules.py ADDITIONAL INFORMATION Reviewed-by: Gonéri Le Bouder <[email protected]> (cherry picked from commit 9401932)
ansibullbot
added
community_review
feature
Docs Build 📝Thank you for contribution!✨ This PR has been merged and your docs changes will be incorporated when they are next published. |
tremble
approved these changes
Nov 1, 2022
softwarefactory-project-zuul
bot
deleted the
patchback/backports/stable-5/9401932f98ef7c6bc412be0487c8e8c054f934eb/pr-1174
branch
1 task
tremble
added a commit
to tremble/amazon.aws
that referenced
this pull request
Feb 9, 2023
tremble
added a commit
to tremble/amazon.aws
that referenced
this pull request
Feb 13, 2023
tremble
added a commit
that referenced
this pull request
Feb 22, 2023
fixes #1353 SUMMARY #1224 exposed that the removal of support for passing both profiles and security tokens was only partially implemented in release 5.0.0 (#834) Since we had already announced that support would be dropped for passing both (back in 2020 with release 1.2.0), I think it's reasonable to still fully drop support in 6.0.0. The documentation was originally very fuzzy about when we'd fallback and use which variables. ISSUE TYPE - Bugfix Pull Request COMPONENT NAME plugins/module_utils/botocore.py plugins/module_utils/modules.py ADDITIONAL INFORMATION
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a backport of PR #1174 as merged into main (9401932).
SUMMARY
When the "ec2" module was first added, it included support for pulling credentials out of the environment variables. 3.5 years later, in Ansible 2.1, support for configuring a 'fallback' directly in the argument specification was added, but we never got around to using it.
This PR finally cleans up the code and lets the argument parser directly handle fallback to environment variables.
ISSUE TYPE
COMPONENT NAME
plugins/module_utils/botocore.py
plugins/module_utils/modules.py
ADDITIONAL INFORMATION