Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[PR #1174/9401932f backport][stable-5] Refacterization of code to use 'fallback' instead of using os.environ #1224

Merged
merged 1 commit into from
Nov 1, 2022
Merged

[PR #1174/9401932f backport][stable-5] Refacterization of code to use 'fallback' instead of using os.environ #1224

merged 1 commit into from
Nov 1, 2022

Commits on Oct 29, 2022

  1. Refacterization of code to use 'fallback' instead of using os.environ (… 

    …#1174)

Refacterization of code to use 'fallback' instead of using os.environ

SUMMARY
When the "ec2" module was first added, it included support for pulling credentials out of the environment variables.  3.5 years later, in Ansible 2.1, support for configuring a 'fallback' directly in the argument specification was added, but we never got around to using it.
This PR finally cleans up the code and lets the argument parser directly handle fallback to environment variables.
ISSUE TYPE

Feature Pull Request

COMPONENT NAME
plugins/module_utils/botocore.py
plugins/module_utils/modules.py
ADDITIONAL INFORMATION

Reviewed-by: Gonéri Le Bouder <[email protected]>
(cherry picked from commit 9401932)
    @tremble @patchback
    tremble authored and patchback[bot] committed Oct 29, 2022
    Configuration menu
    Copy the full SHA
    affbde8 View commit details
    Browse the repository at this point in the history