-
Notifications
You must be signed in to change notification settings - Fork 341
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ec2_snapshot - boto3 migration #356
Merged
ansible-zuul
merged 4 commits into
ansible-collections:main
from
tremble:boto3/ec2_snapshot
May 5, 2021
Merged
ec2_snapshot - boto3 migration #356
ansible-zuul
merged 4 commits into
ansible-collections:main
from
tremble:boto3/ec2_snapshot
May 5, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tremble
force-pushed
the
boto3/ec2_snapshot
branch
from
May 4, 2021 17:10
ce0b57a
to
a3087bf
Compare
jillr
reviewed
May 4, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks @tremble, this looks pretty good.
tremble
force-pushed
the
boto3/ec2_snapshot
branch
from
May 5, 2021 03:37
a3087bf
to
40f8a48
Compare
abikouo
approved these changes
May 5, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
alinabuzachis
approved these changes
May 5, 2021
Two cloud LGTMs, letting zuul / gate do its thing |
jillr
pushed a commit
to jillr/amazon.aws
that referenced
this pull request
May 10, 2021
…-collections#356) * syncing module and tests for uptime with tons of help from Yanis, we now have uptime in there * updating pr with fixes from suggestions adding to ansible-collections/community.aws#356 with comments from @tremble and @duderamos * Create 356_add_minimum_uptime_parameter.yaml adding changelog fragment per @gravesm suggestion * Update 356_add_minimum_uptime_parameter.yaml last comment from @tremble Co-authored-by: Sean Cavanaugh <[email protected]>
jillr
pushed a commit
to jillr/amazon.aws
that referenced
this pull request
May 10, 2021
…-collections#356) * syncing module and tests for uptime with tons of help from Yanis, we now have uptime in there * updating pr with fixes from suggestions adding to ansible-collections/community.aws#356 with comments from @tremble and @duderamos * Create 356_add_minimum_uptime_parameter.yaml adding changelog fragment per @gravesm suggestion * Update 356_add_minimum_uptime_parameter.yaml last comment from @tremble Co-authored-by: Sean Cavanaugh <[email protected]>
jillr
pushed a commit
to jillr/amazon.aws
that referenced
this pull request
May 13, 2021
…-collections#356) * syncing module and tests for uptime with tons of help from Yanis, we now have uptime in there * updating pr with fixes from suggestions adding to ansible-collections/community.aws#356 with comments from @tremble and @duderamos * Create 356_add_minimum_uptime_parameter.yaml adding changelog fragment per @gravesm suggestion * Update 356_add_minimum_uptime_parameter.yaml last comment from @tremble Co-authored-by: Sean Cavanaugh <[email protected]>
softwarefactory-project-zuul bot
pushed a commit
that referenced
this pull request
Apr 23, 2022
…ts is 5 (#786) Create extra snapshots for ec2_snapshot_info test - minimum max_results is 5 This is a partial backport of PR #356 as merged into main (b7087f4). SUMMARY Fixes a bug in the integration test ISSUE TYPE Bugfix Pull Request COMPONENT NAME ec2_snapshot_info ADDITIONAL INFORMATION Reviewed-by: Alina Buzachis <None>
abikouo
pushed a commit
to abikouo/amazon.aws
that referenced
this pull request
Sep 18, 2023
…-collections#356) * syncing module and tests for uptime with tons of help from Yanis, we now have uptime in there * updating pr with fixes from suggestions adding to ansible-collections/community.aws#356 with comments from @tremble and @duderamos * Create 356_add_minimum_uptime_parameter.yaml adding changelog fragment per @gravesm suggestion * Update 356_add_minimum_uptime_parameter.yaml last comment from @tremble Co-authored-by: Sean Cavanaugh <[email protected]>
abikouo
pushed a commit
to abikouo/amazon.aws
that referenced
this pull request
Sep 18, 2023
…-collections#356) * syncing module and tests for uptime with tons of help from Yanis, we now have uptime in there * updating pr with fixes from suggestions adding to ansible-collections/community.aws#356 with comments from @tremble and @duderamos * Create 356_add_minimum_uptime_parameter.yaml adding changelog fragment per @gravesm suggestion * Update 356_add_minimum_uptime_parameter.yaml last comment from @tremble Co-authored-by: Sean Cavanaugh <[email protected]>
abikouo
pushed a commit
to abikouo/amazon.aws
that referenced
this pull request
Oct 24, 2023
…-collections#356) * syncing module and tests for uptime with tons of help from Yanis, we now have uptime in there * updating pr with fixes from suggestions adding to ansible-collections/community.aws#356 with comments from @tremble and @duderamos * Create 356_add_minimum_uptime_parameter.yaml adding changelog fragment per @gravesm suggestion * Update 356_add_minimum_uptime_parameter.yaml last comment from @tremble Co-authored-by: Sean Cavanaugh <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Migrate ec2_snapshot to boto3
ISSUE TYPE
COMPONENT NAME
ec2_snapshot
ADDITIONAL INFORMATION
Assumes Python 3.x (datetime.timezone.utc)