add uptime parameter for ec2_instance_info module in minutes #356

IPvSean · 2021-01-12T20:38:19Z

SUMMARY

with tons of help from Yanis, we now have uptime in there

this PR is based on the PR #316

example:

    - name: grab info
      community.aws.ec2_instance_info:
        region: "{{ ec2_region }}"
        uptime: 10200
        filters:
          instance-state-name: [ "running" ]
      register: ec2_node_info

this would only register instances that have been up for 10200 minutes (or 170 hours or ~7 days)

ISSUE TYPE

Feature Pull Request

COMPONENT NAME

ec2_instance_info

ADDITIONAL INFORMATION

see #316 for the commentary on the last PR where I fixed information for @jillr and @gravesm

with tons of help from Yanis, we now have uptime in there

ansibullbot · 2021-01-13T00:23:41Z

cc @Shaps @michaeljs1990 @s-hertel @tremble @wimnat
click here for bot help

plugins/modules/ec2_instance_info.py

tremble

Thanks for taking the time to submit this PR.

Some minor issues, but nothing significant from my side.

tests/integration/targets/ec2_instance/roles/ec2_instance/tasks/uptime.yml

plugins/modules/ec2_instance_info.py

@tremble

adding to ansible-collections#356 with comments from @tremble and @duderamos

IPvSean · 2021-01-13T15:37:07Z

@tremble , I think I made all the changes... can you verify for me 🙏

gravesm

This looks pretty good from my side. Could you add a changelog fragment? https://docs.ansible.com/ansible/latest/community/development_process.html#community-changelogs

@gravesm

adding changelog fragment per @gravesm suggestion

IPvSean · 2021-01-13T16:24:52Z

should be there now @gravesm !

tremble

Minor tweak in wording, but otherwise I think we're good

tremble · 2021-01-13T16:34:56Z

changelogs/fragments/356_add_minimum_uptime_parameter.yaml

@@ -0,0 +1,3 @@
+---
+minor_changes:
+- adding minimum_uptime and alias uptime to filter instances that have only been online for certain duration of time in minutes


Suggested change

- adding minimum_uptime and alias uptime to filter instances that have only been online for certain duration of time in minutes

- ec2_instance_info - added ``minimum_uptime`` option with alias ``uptime`` for filtering instances that have only been online for certain duration of time in minutes (https://github.com/ansible-collections/community.aws/pull/356).

@tremble

last comment from @tremble

IPvSean · 2021-01-13T17:16:43Z

ok made the change, thanks for all the help @tremble

@tremble

…-collections#356) * syncing module and tests for uptime with tons of help from Yanis, we now have uptime in there * updating pr with fixes from suggestions adding to ansible-collections/community.aws#356 with comments from @tremble and @duderamos * Create 356_add_minimum_uptime_parameter.yaml adding changelog fragment per @gravesm suggestion * Update 356_add_minimum_uptime_parameter.yaml last comment from @tremble Co-authored-by: Sean Cavanaugh <[email protected]>

@tremble

…-collections#356) * syncing module and tests for uptime with tons of help from Yanis, we now have uptime in there * updating pr with fixes from suggestions adding to ansible-collections/community.aws#356 with comments from @tremble and @duderamos * Create 356_add_minimum_uptime_parameter.yaml adding changelog fragment per @gravesm suggestion * Update 356_add_minimum_uptime_parameter.yaml last comment from @tremble Co-authored-by: Sean Cavanaugh <[email protected]>

@tremble

…-collections#356) * syncing module and tests for uptime with tons of help from Yanis, we now have uptime in there * updating pr with fixes from suggestions adding to ansible-collections/community.aws#356 with comments from @tremble and @duderamos * Create 356_add_minimum_uptime_parameter.yaml adding changelog fragment per @gravesm suggestion * Update 356_add_minimum_uptime_parameter.yaml last comment from @tremble Co-authored-by: Sean Cavanaugh <[email protected]>

@tremble

…-collections#356) * syncing module and tests for uptime with tons of help from Yanis, we now have uptime in there * updating pr with fixes from suggestions adding to ansible-collections/community.aws#356 with comments from @tremble and @duderamos * Create 356_add_minimum_uptime_parameter.yaml adding changelog fragment per @gravesm suggestion * Update 356_add_minimum_uptime_parameter.yaml last comment from @tremble Co-authored-by: Sean Cavanaugh <[email protected]>

@tremble

…-collections#356) * syncing module and tests for uptime with tons of help from Yanis, we now have uptime in there * updating pr with fixes from suggestions adding to ansible-collections#356 with comments from @tremble and @duderamos * Create 356_add_minimum_uptime_parameter.yaml adding changelog fragment per @gravesm suggestion * Update 356_add_minimum_uptime_parameter.yaml last comment from @tremble Co-authored-by: Sean Cavanaugh <[email protected]>

@tremble

…-collections#356) * syncing module and tests for uptime with tons of help from Yanis, we now have uptime in there * updating pr with fixes from suggestions adding to ansible-collections#356 with comments from @tremble and @duderamos * Create 356_add_minimum_uptime_parameter.yaml adding changelog fragment per @gravesm suggestion * Update 356_add_minimum_uptime_parameter.yaml last comment from @tremble Co-authored-by: Sean Cavanaugh <[email protected]>

@tremble

…-collections#356) * syncing module and tests for uptime with tons of help from Yanis, we now have uptime in there * updating pr with fixes from suggestions adding to ansible-collections#356 with comments from @tremble and @duderamos * Create 356_add_minimum_uptime_parameter.yaml adding changelog fragment per @gravesm suggestion * Update 356_add_minimum_uptime_parameter.yaml last comment from @tremble Co-authored-by: Sean Cavanaugh <[email protected]>

ec2_snapshot - boto3 migration Reviewed-by: Mark Chappell https://github.com/tremble

@tremble

…-collections#356) * syncing module and tests for uptime with tons of help from Yanis, we now have uptime in there * updating pr with fixes from suggestions adding to ansible-collections/community.aws#356 with comments from @tremble and @duderamos * Create 356_add_minimum_uptime_parameter.yaml adding changelog fragment per @gravesm suggestion * Update 356_add_minimum_uptime_parameter.yaml last comment from @tremble Co-authored-by: Sean Cavanaugh <[email protected]>

@tremble

…-collections#356) * syncing module and tests for uptime with tons of help from Yanis, we now have uptime in there * updating pr with fixes from suggestions adding to ansible-collections/community.aws#356 with comments from @tremble and @duderamos * Create 356_add_minimum_uptime_parameter.yaml adding changelog fragment per @gravesm suggestion * Update 356_add_minimum_uptime_parameter.yaml last comment from @tremble Co-authored-by: Sean Cavanaugh <[email protected]>

syncing module and tests for uptime

5afda6c

with tons of help from Yanis, we now have uptime in there

duderamos reviewed Jan 13, 2021

View reviewed changes

plugins/modules/ec2_instance_info.py Outdated Show resolved Hide resolved

tremble requested changes Jan 13, 2021

View reviewed changes

plugins/modules/ec2_instance_info.py Outdated Show resolved Hide resolved

updating pr with fixes from suggestions

ebe23ca

adding to ansible-collections#356 with comments from @tremble and @duderamos

IPvSean requested a review from tremble January 13, 2021 15:42

gravesm requested changes Jan 13, 2021

View reviewed changes

Create 356_add_minimum_uptime_parameter.yaml

21127ef

adding changelog fragment per @gravesm suggestion

tremble requested changes Jan 13, 2021

View reviewed changes

Update 356_add_minimum_uptime_parameter.yaml

eec5100

last comment from @tremble

tremble approved these changes Jan 13, 2021

View reviewed changes

tremble requested a review from gravesm January 13, 2021 17:26

gravesm approved these changes Jan 13, 2021

View reviewed changes

gravesm merged commit 7ff2133 into ansible-collections:main Jan 13, 2021

alinabuzachis pushed a commit to alinabuzachis/community.aws that referenced this pull request May 25, 2022

ec2_snapshot - boto3 migration (ansible-collections#356)

b7087f4

ec2_snapshot - boto3 migration Reviewed-by: Mark Chappell https://github.com/tremble

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

add uptime parameter for ec2_instance_info module in minutes #356

add uptime parameter for ec2_instance_info module in minutes #356

IPvSean commented Jan 12, 2021

ansibullbot commented Jan 13, 2021

tremble left a comment

IPvSean commented Jan 13, 2021

gravesm left a comment

IPvSean commented Jan 13, 2021

tremble left a comment

tremble Jan 13, 2021

IPvSean commented Jan 13, 2021

	- adding minimum_uptime and alias uptime to filter instances that have only been online for certain duration of time in minutes
	- ec2_instance_info - added ``minimum_uptime`` option with alias ``uptime`` for filtering instances that have only been online for certain duration of time in minutes (https://github.com/ansible-collections/community.aws/pull/356).

add uptime parameter for ec2_instance_info module in minutes #356

add uptime parameter for ec2_instance_info module in minutes #356

Conversation

IPvSean commented Jan 12, 2021

SUMMARY

ISSUE TYPE

COMPONENT NAME

ADDITIONAL INFORMATION

ansibullbot commented Jan 13, 2021

tremble left a comment

Choose a reason for hiding this comment

IPvSean commented Jan 13, 2021

gravesm left a comment

Choose a reason for hiding this comment

IPvSean commented Jan 13, 2021

tremble left a comment

Choose a reason for hiding this comment

tremble Jan 13, 2021

Choose a reason for hiding this comment

IPvSean commented Jan 13, 2021