Modify boot option handling on Linux systems #182
Conversation
saito-hideki
changed the title
saito-hideki
changed the title
saito-hideki
changed the title
saito-hideki
changed the title
saito-hideki
changed the title
|
@quidame I have fixed it according to your advice. I would appreciate it if you could review it. Thanks! |
plugins/modules/mount.py
Outdated
| if 'noauto' in opts: | ||
| args['warnings'].append("Ignore the 'boot' due to 'opts' contains 'noauto'.") | ||
| elif not module.params['boot']: | ||
| args['boot'] = 'no' |
There was a problem hiding this comment.
what is the point to set it as a string rather than a boolean ?
There was a problem hiding this comment.
Hi! thank you for the review. That was to match the return value type with Solaris. For Solaris, return value includes boot but it is string.
I have fixed it to use boolean but eventually, I think that we also need to change the type of return value for Solaris. But I think it's probably better to do it in another PR.
@quidame I would appreciate your advice on this :)
There was a problem hiding this comment.
#185 has been merged to main branch.
There was a problem hiding this comment.
Could you please rebase this branch? I guess the conflicts are because of #185 you've just mentioned.
saito-hideki
changed the title
saito-hideki
changed the title
|
the changelog-fragment check seems to be fixed and should pass now |
|
Closing and re-opening for CI trigger. |
SUMMARY
Modify boot option handling on Linux systems:
noautooption ifbootisnoon Linux systemoptscontainsnoautoordefaults, thebootoption will be ignorednoautois not specified, the default behavior will beauto, soboot: yesdoes not explicitly setauto.ISSUE TYPE
COMPONENT NAME
ADDITIONAL INFORMATION
None