Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[mount] Fix boot option handling on Solaris correctly #185

Merged
merged 1 commit into from
May 27, 2021
Merged

[mount] Fix boot option handling on Solaris correctly #185

merged 1 commit into from
May 27, 2021

Conversation

saito-hideki
Copy link
Collaborator

@saito-hideki saito-hideki commented May 11, 2021 •
edited
Loading

SUMMARY

Fix boot option handling on Solaris correctly when it specified false(or no).

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME
  • ansible.posix.mount
ADDITIONAL INFORMATION

None

@saito-hideki saito-hideki mentioned this pull request May 11, 2021
Closed
quidame
quidame approved these changes May 12, 2021
View reviewed changes
Copy link
Contributor

@quidame quidame left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@saito-hideki thanks for fixing this !

@quidame
Copy link
Contributor

quidame commented May 12, 2021

@saito-hideki could you change the PR description, please (- Addresses issue #issue => Fixes #issue) ? So that this bugfix would be referenced as such ?

@saito-hideki
Copy link
Collaborator Author

Hi @quidame
Than you for the review! I have fixed PR description and the commit message as well :)

@Akasurde Akasurde closed this May 24, 2021
@Akasurde Akasurde reopened this May 24, 2021
@Akasurde
Copy link
Member

/recheck

@Akasurde Akasurde closed this May 25, 2021
@Akasurde
Copy link
Member

Closing and re-opening for CI trigger.

@Akasurde Akasurde reopened this May 25, 2021
@saito-hideki saito-hideki reopened this May 27, 2021
@saito-hideki
Copy link
Collaborator Author

Closing and re-opening for CI trigger.

@Akasurde Akasurde added the gate Gate PR in Zuul CI (Obsolete: Please set "mergeit" instead of "gate") label May 27, 2021
@ansible-zuul ansible-zuul bot merged commit 5d0c8e4 into ansible-collections:main May 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@quidame quidame quidame approved these changes

Assignees
No one assigned
Labels
gate Gate PR in Zuul CI (Obsolete: Please set "mergeit" instead of "gate")
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[mount] always set yes to "mount at boot" on Solaris even if boot set false
3 participants
@saito-hideki @quidame @Akasurde