Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport elb_target_group_info PRs to stable-3 #1019

Merged

Conversation

marknet15
Copy link
Contributor

SUMMARY

Backport elb_target_group_info PRs to stable-3

Original PRs:
#1001 (backoff)
#1015 (fix)

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

elb_target_group_info

ADDITIONAL INFORMATION

Add backoff logic to elb_target_group_info

SUMMARY
From time to time rate limiting failures occur on the usage of this module, this PR adds backoff logic to the module to improve its stability.
An exception occurred during task execution. To see the full traceback, use -vvv. The error was: botocore.exceptions.ClientError: An error occurred (Throttling) when calling the DescribeTargetGroups operation (reached max retries: 4): Rate exceeded
fatal: [10_184_0_132 -> 127.0.0.1]: FAILED! => changed=false 
  boto3_version: 1.20.34
  botocore_version: 1.23.34
  error:
    code: Throttling
    message: Rate exceeded
    type: Sender
  msg: 'Failed to list target groups: An error occurred (Throttling) when calling the DescribeTargetGroups operation (reached max retries: 4): Rate exceeded'
  response_metadata:
    http_headers:
      content-length: '271'
      content-type: text/xml
      date: Wed, 16 Mar 2022 09:50:24 GMT
      x-amzn-requestid: xxxxx
    http_status_code: 400
    max_attempts_reached: true
    request_id: xxxxx
    retry_attempts: 4

ISSUE TYPE

Bugfix Pull Request

COMPONENT NAME
elb_target_group_info
ADDITIONAL INFORMATION

Reviewed-by: Markus Bergholz <[email protected]>
Reviewed-by: Alina Buzachis <None>
Fix introduced bug in elb_target_group_info

SUMMARY
Fix bug introduced here: ansible-collections#1001
ISSUE TYPE

Bugfix Pull Request

COMPONENT NAME
elb_target_group_info
ADDITIONAL INFORMATION

Reviewed-by: Alina Buzachis <None>
Reviewed-by: Markus Bergholz <[email protected]>
@ansibullbot
Copy link

@ansibullbot ansibullbot added bug This issue/PR relates to a bug community_review module module needs_triage plugins plugin (any type) labels Mar 26, 2022
@markuman markuman added the mergeit Merge the PR (SoftwareFactory) label Mar 26, 2022
@softwarefactory-project-zuul softwarefactory-project-zuul bot merged commit 94c7ca8 into ansible-collections:stable-3 Mar 26, 2022
@marknet15 marknet15 deleted the stable-3 branch March 29, 2022 09:56
abikouo pushed a commit to abikouo/community.aws that referenced this pull request Oct 24, 2023
…ions#1019)

tests: some ec2_instance targets are slower than normal

Depends-On: ansible/ansible-zuul-jobs#1625
Dedicate more time for the execution of some slow ec2_instance targets.
See: ansible-collections#978 (comment)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug This issue/PR relates to a bug community_review mergeit Merge the PR (SoftwareFactory) module module plugins plugin (any type)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants