Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[PR #966/86741fed backport][stable-3] elb_target_group - support target_type alb #978

Merged
merged 1 commit into from
Mar 11, 2022
Merged

[PR #966/86741fed backport][stable-3] elb_target_group - support target_type alb #978

merged 1 commit into from
Mar 11, 2022

Conversation

patchback[bot]
Copy link

@patchback patchback bot commented Mar 11, 2022

This is a backport of PR #966 as merged into main (86741fe).

SUMMARY
ISSUE TYPE
  • Feature Pull Request
COMPONENT NAME

elb_target_group

@jatorcasso @patchback
elb_target_group - support target_type alb (#966)
b000864 
elb_target_group - support target_type alb

SUMMARY

Add support for target_type alb and integration tests
Update documentation for clarity
Fixes #891

ISSUE TYPE

Feature Pull Request

COMPONENT NAME
elb_target_group

Reviewed-by: Mark Woolley <[email protected]>
Reviewed-by: Mandar Kulkarni <[email protected]>
Reviewed-by: Alina Buzachis <None>
Reviewed-by: Markus Bergholz <[email protected]>
(cherry picked from commit 86741fe)
@patchback patchback bot mentioned this pull request Mar 11, 2022
Merged
@ansibullbot
Copy link

cc @jillr @markuman @s-hertel @tremble
click here for bot help

@ansibullbot ansibullbot added community_review feature This issue/PR relates to a feature request integration tests/integration module module needs_triage new_contributor Help guide this first time contributor plugins plugin (any type) tests tests labels Mar 11, 2022
@markuman markuman added the mergeit Merge the PR (SoftwareFactory) label Mar 11, 2022
@softwarefactory-project-zuul
Copy link
Contributor

Build succeeded (gate pipeline).

@softwarefactory-project-zuul softwarefactory-project-zuul bot merged commit 88dcf46 into stable-3 Mar 11, 2022
@softwarefactory-project-zuul softwarefactory-project-zuul bot deleted the patchback/backports/stable-3/86741fed23c9022830396ae3b206203989b41b42/pr-966 branch March 11, 2022 10:36
@hectoralicea
Copy link

so what's the spec for targets when target_type is alb?

- name: install-nlb-to-ingress | Create a target group with a default health check
  community.aws.elb_target_group:
    name: '{{ inner_item.ingress_group_name }}-{{ aws_environment_name }}-tg'
    protocol: tcp
    purge_tags: no
    port: 80
    vpc_id: '{{ vpc_id }}'
    state: present
    target_type: alb
    targets: ????????????
    health_check_path: /healthz
    health_check_protocol: http
  register: nlb_target_group_provision_result

@markuman
Copy link
Member

@hectoralicea

If the target type is alb , specify the ARN of the Application Load Balancer target.
https://github.com/ansible-collections/community.aws/pull/966/files#diff-2c1c6b6915c4678f611809c13fca7baf3b17b239efd502403f050f52d2f03eafR146

    
    - name: Create a target group with instance targets
      community.aws.elb_target_group:
        name: mytargetgroup1
        protocol: TCP
        port: 81
        vpc_id: vpc-3244zgf
        target_type: alb
        targets:
          - Id: arn:aws:elasticloadbalancing:eu-central-1:123456789:loadbalancer/app/intern/a5a1efe5239a3df
            Port: 80
        state: present
        wait_timeout: 200

abikouo pushed a commit to abikouo/community.aws that referenced this pull request Oct 24, 2023
@goneri
tests: some ec2_instance jobs are slower than normal (ansible-collect…
a079a0d 
…ions#1019)

tests: some ec2_instance targets are slower than normal

Depends-On: ansible/ansible-zuul-jobs#1625
Dedicate more time for the execution of some slow ec2_instance targets.
See: ansible-collections#978 (comment)
abikouo pushed a commit to abikouo/community.aws that referenced this pull request Oct 24, 2023
@alinabuzachis
Adjust booleans from yes/no to true/false (ansible-collections#978)
b4298bd 
Adjust booleans from yes/no to true/false

SUMMARY

As per ansible-community/community-topics#116
See also ansible-collections#1420
Closes: ansible-collections#1041
ISSUE TYPE


Docs Pull Request

COMPONENT NAME

several
ADDITIONAL INFORMATION

Reviewed-by: Mark Chappell <None>
Reviewed-by: Bikouo Aubin <None>
Reviewed-by: Gonéri Le Bouder <[email protected]>
abikouo pushed a commit to abikouo/community.aws that referenced this pull request Oct 24, 2023
@tremble
Update bools in ec2_instance (ansible-collections#1055)
b9de59d 
Update bools documentation in ec2_instance

SUMMARY
See also ansible-collections#1041
ISSUE TYPE

Docs Pull Request

COMPONENT NAME
ec2_instance
ADDITIONAL INFORMATION
Split from ansible-collections#978 to work around CI issues

Reviewed-by: Alina Buzachis <None>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
community_review feature This issue/PR relates to a feature request integration tests/integration mergeit Merge the PR (SoftwareFactory) module module new_contributor Help guide this first time contributor plugins plugin (any type) tests tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ansibullbot @hectoralicea @markuman @jatorcasso