s3-lifecycle: fix remove rule with empty prefix #1398
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ansibullbot
added
bug
|
Hi, Thanks for taking the time to submit this PR. If possible please update the integration tests at Mark |
clwluvw
force-pushed
the
s3-lifecycle-prefix
branch
from
ff2eddc
to
c306c9c
Compare
tremble
approved these changes
Aug 8, 2022
tremble
force-pushed
the
s3-lifecycle-prefix
branch
from
5224729
to
33f0cf2
Compare
ansibullbot
added
integration
In case of removing a lifecycle policy without a prefix, there will be no prefix key in the existing_rule filter Signed-off-by: Seena Fallah <[email protected]>
tremble
force-pushed
the
s3-lifecycle-prefix
branch
from
33f0cf2
to
615f9af
Compare
tremble
added
backport-3
Backport to stable-3: 💚 backport PR created✅ Backport PR branch: Backported as #1402 🤖 @patchback |
Backport to stable-4: 💚 backport PR created✅ Backport PR branch: Backported as #1401 🤖 @patchback |
patchback bot
pushed a commit
that referenced
this pull request
Aug 9, 2022
s3-lifecycle: fix remove rule with empty prefix SUMMARY In case of removing a lifecycle policy without a prefix, there will be no prefix key in the existing_rule filter Signed-off-by: Seena Fallah [email protected] ISSUE TYPE Bugfix Pull Request COMPONENT NAME s3_lifecycle Reviewed-by: Mark Chappell <None> (cherry picked from commit 4c67633)
patchback bot
pushed a commit
that referenced
this pull request
Aug 9, 2022
s3-lifecycle: fix remove rule with empty prefix SUMMARY In case of removing a lifecycle policy without a prefix, there will be no prefix key in the existing_rule filter Signed-off-by: Seena Fallah [email protected] ISSUE TYPE Bugfix Pull Request COMPONENT NAME s3_lifecycle Reviewed-by: Mark Chappell <None> (cherry picked from commit 4c67633)
This was referenced Aug 9, 2022
softwarefactory-project-zuul bot
pushed a commit
that referenced
this pull request
Aug 9, 2022
[PR #1398/4c67633c backport][stable-4] s3-lifecycle: fix remove rule with empty prefix This is a backport of PR #1398 as merged into main (4c67633). SUMMARY In case of removing a lifecycle policy without a prefix, there will be no prefix key in the existing_rule filter Signed-off-by: Seena Fallah [email protected] ISSUE TYPE Bugfix Pull Request COMPONENT NAME s3_lifecycle Reviewed-by: Mark Chappell <None>
softwarefactory-project-zuul bot
pushed a commit
that referenced
this pull request
Aug 9, 2022
[PR #1398/4c67633c backport][stable-3] s3-lifecycle: fix remove rule with empty prefix This is a backport of PR #1398 as merged into main (4c67633). SUMMARY In case of removing a lifecycle policy without a prefix, there will be no prefix key in the existing_rule filter Signed-off-by: Seena Fallah [email protected] ISSUE TYPE Bugfix Pull Request COMPONENT NAME s3_lifecycle Reviewed-by: Mark Chappell <None>
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
In case of removing a lifecycle policy without a prefix, there will be no prefix key in the existing_rule filter
Signed-off-by: Seena Fallah [email protected]
ISSUE TYPE
COMPONENT NAME
s3_lifecycle