Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PR #1398/4c67633c backport][stable-4] s3-lifecycle: fix remove rule with empty prefix #1401

Conversation

patchback[bot]
Copy link

@patchback patchback bot commented Aug 9, 2022

This is a backport of PR #1398 as merged into main (4c67633).

SUMMARY

In case of removing a lifecycle policy without a prefix, there will be no prefix key in the existing_rule filter

Signed-off-by: Seena Fallah [email protected]

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

s3_lifecycle

s3-lifecycle: fix remove rule with empty prefix

SUMMARY
In case of removing a lifecycle policy without a prefix, there will be no prefix key in the existing_rule filter
Signed-off-by: Seena Fallah [email protected]
ISSUE TYPE

Bugfix Pull Request

COMPONENT NAME
s3_lifecycle

Reviewed-by: Mark Chappell <None>
(cherry picked from commit 4c67633)
@softwarefactory-project-zuul
Copy link
Contributor

Build succeeded.

✔️ ansible-galaxy-importer SUCCESS in 4m 28s
✔️ build-ansible-collection SUCCESS in 5m 49s
✔️ ansible-test-sanity-docker-devel SUCCESS in 11m 22s (non-voting)
✔️ ansible-test-sanity-docker-milestone SUCCESS in 9m 32s
✔️ ansible-test-sanity-docker-stable-2.12 SUCCESS in 11m 37s
✔️ ansible-test-sanity-docker-stable-2.13 SUCCESS in 11m 03s
✔️ ansible-test-units-community-aws-python38 SUCCESS in 6m 25s
✔️ ansible-test-units-community-aws-python39 SUCCESS in 6m 42s
✔️ ansible-test-splitter SUCCESS in 3m 08s
✔️ integration-community.aws-1 SUCCESS in 22m 53s
⚠️ integration-community.aws-2 SKIPPED
⚠️ integration-community.aws-3 SKIPPED
⚠️ integration-community.aws-4 SKIPPED
⚠️ integration-community.aws-5 SKIPPED
⚠️ integration-community.aws-6 SKIPPED
⚠️ integration-community.aws-7 SKIPPED
⚠️ integration-community.aws-8 SKIPPED
⚠️ integration-community.aws-9 SKIPPED
⚠️ integration-community.aws-10 SKIPPED
⚠️ integration-community.aws-11 SKIPPED
⚠️ integration-community.aws-12 SKIPPED
⚠️ integration-community.aws-13 SKIPPED

@ansibullbot
Copy link

@ansibullbot ansibullbot added bug This issue/PR relates to a bug community_review integration tests/integration module module needs_triage new_contributor Help guide this first time contributor plugins plugin (any type) tests tests labels Aug 9, 2022
@tremble tremble added the mergeit Merge the PR (SoftwareFactory) label Aug 9, 2022
@softwarefactory-project-zuul
Copy link
Contributor

Build succeeded (gate pipeline).

✔️ ansible-galaxy-importer SUCCESS in 5m 26s
✔️ build-ansible-collection SUCCESS in 5m 29s
✔️ ansible-test-sanity-docker-devel SUCCESS in 13m 06s (non-voting)
✔️ ansible-test-sanity-docker-milestone SUCCESS in 12m 28s
✔️ ansible-test-sanity-docker-stable-2.12 SUCCESS in 12m 02s
✔️ ansible-test-sanity-docker-stable-2.13 SUCCESS in 11m 25s
✔️ ansible-test-units-community-aws-python38 SUCCESS in 10m 53s
✔️ ansible-test-units-community-aws-python39 SUCCESS in 8m 45s
✔️ ansible-test-splitter SUCCESS in 2m 37s
✔️ integration-community.aws-1 SUCCESS in 24m 29s
⚠️ integration-community.aws-2 SKIPPED
⚠️ integration-community.aws-3 SKIPPED
⚠️ integration-community.aws-4 SKIPPED
⚠️ integration-community.aws-5 SKIPPED
⚠️ integration-community.aws-6 SKIPPED
⚠️ integration-community.aws-7 SKIPPED
⚠️ integration-community.aws-8 SKIPPED
⚠️ integration-community.aws-9 SKIPPED
⚠️ integration-community.aws-10 SKIPPED
⚠️ integration-community.aws-11 SKIPPED
⚠️ integration-community.aws-12 SKIPPED
⚠️ integration-community.aws-13 SKIPPED

@softwarefactory-project-zuul softwarefactory-project-zuul bot merged commit 41d674e into stable-4 Aug 9, 2022
@softwarefactory-project-zuul softwarefactory-project-zuul bot deleted the patchback/backports/stable-4/4c67633cea15c214f59904ccb49427c8fbaa3435/pr-1398 branch August 9, 2022 10:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug This issue/PR relates to a bug community_review integration tests/integration mergeit Merge the PR (SoftwareFactory) module module new_contributor Help guide this first time contributor plugins plugin (any type) tests tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants