ecs_ecr - Fix RepositoryNotFoundException when creating Repositories in check mode
#1550
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… mode also fixes and re-enables basic integration tests
ansibullbot
added
bug
tremble
added
backport-4
markuman
approved these changes
Oct 7, 2022
Backport to stable-4: 💚 backport PR created✅ Backport PR branch: Backported as #1552 🤖 @patchback |
softwarefactory-project-zuul bot
pushed a commit
that referenced
this pull request
Oct 7, 2022
ecs_ecr - Use compare_policies instead of naive dict sort Depends-On: #1550 SUMMARY When comparing policies on the repos ecs_ecr currently uses a very naive sort function. Since we have something more comprehensive, use it. ISSUE TYPE Feature Pull Request COMPONENT NAME plugins/modules/ecs_ecr.py ADDITIONAL INFORMATION ecs_ecr is currently the only module using sort_json_policy_dict and it has poor test coverage. Reviewed-by: Markus Bergholz <[email protected]>
patchback bot
pushed a commit
that referenced
this pull request
Oct 7, 2022
…s in check mode (#1550) ecs_ecr - Fix `RepositoryNotFoundException` when creating Repositories in check mode SUMMARY When trying to create a repository in check mode the module throws a RepositoryNotFoundException trying to access policy objects on the repositories also fixes and re-enables basic integration tests ISSUE TYPE Bugfix Pull Request COMPONENT NAME ecs_ecr ADDITIONAL INFORMATION Reviewed-by: Markus Bergholz <[email protected]> (cherry picked from commit 187649d)
Backport to stable-5: 💚 backport PR created✅ Backport PR branch: Backported as #1553 🤖 @patchback |
patchback bot
pushed a commit
that referenced
this pull request
Oct 7, 2022
…s in check mode (#1550) ecs_ecr - Fix `RepositoryNotFoundException` when creating Repositories in check mode SUMMARY When trying to create a repository in check mode the module throws a RepositoryNotFoundException trying to access policy objects on the repositories also fixes and re-enables basic integration tests ISSUE TYPE Bugfix Pull Request COMPONENT NAME ecs_ecr ADDITIONAL INFORMATION Reviewed-by: Markus Bergholz <[email protected]> (cherry picked from commit 187649d)
softwarefactory-project-zuul bot
pushed a commit
that referenced
this pull request
Oct 10, 2022
…s in check mode (#1550) (#1553) [PR #1550/187649dc backport][stable-5] ecs_ecr - Fix `RepositoryNotFoundException` when creating Repositories in check mode This is a backport of PR #1550 as merged into main (187649d). SUMMARY When trying to create a repository in check mode the module throws a RepositoryNotFoundException trying to access policy objects on the repositories also fixes and re-enables basic integration tests ISSUE TYPE Bugfix Pull Request COMPONENT NAME ecs_ecr ADDITIONAL INFORMATION Reviewed-by: Mark Chappell <None>
softwarefactory-project-zuul bot
pushed a commit
that referenced
this pull request
Oct 10, 2022
…s in check mode (#1550) (#1552) [PR #1550/187649dc backport][stable-4] ecs_ecr - Fix `RepositoryNotFoundException` when creating Repositories in check mode This is a backport of PR #1550 as merged into main (187649d). SUMMARY When trying to create a repository in check mode the module throws a RepositoryNotFoundException trying to access policy objects on the repositories also fixes and re-enables basic integration tests ISSUE TYPE Bugfix Pull Request COMPONENT NAME ecs_ecr ADDITIONAL INFORMATION Reviewed-by: Mark Chappell <None>
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
When trying to create a repository in check mode the module throws a
RepositoryNotFoundExceptiontrying to access policy objects on the repositoriesalso fixes and re-enables basic integration tests
ISSUE TYPE
COMPONENT NAME
ecs_ecr
ADDITIONAL INFORMATION