ecs_ecr - Use compare_policies instead of naive dict sort #1551
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as resolved.
This comment was marked as resolved.
ansibullbot
added
community_review
feature
markuman
approved these changes
Oct 7, 2022
abikouo
pushed a commit
to abikouo/community.aws
that referenced
this pull request
Oct 24, 2023
…ing to pull a list of regions (ansible-collections#1552) inventory plugins - Hard code fall-back region to connect to when trying to pull a list of regions SUMMARY fixes: ansible-collections#1551 If no regions and no region is provided, then botocore will sometimes refuse to connect to the EC2 endpoint for us to then pull a list of regions... ISSUE TYPE Bugfix Pull Request COMPONENT NAME aws_ec2 inventory plugin ADDITIONAL INFORMATION Nominally botocore should be falling back to a default region, but there are no guarantees Reviewed-by: Alina Buzachis
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends-On: #1550
SUMMARY
When comparing policies on the repos ecs_ecr currently uses a very naive sort function. Since we have something more comprehensive, use it.
ISSUE TYPE
COMPONENT NAME
plugins/modules/ecs_ecr.py
ADDITIONAL INFORMATION
ecs_ecr is currently the only module using sort_json_policy_dict and it has poor test coverage.