ec2_metrics_alarm test - Create the instance in the subnet we just created #212
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ated not the default VPC
jillr
approved these changes
Aug 28, 2020
alinabuzachis
pushed a commit
to alinabuzachis/community.aws
that referenced
this pull request
Jul 19, 2021
…ated not the default VPC (ansible-collections#212)
alinabuzachis
pushed a commit
to alinabuzachis/community.aws
that referenced
this pull request
Jul 19, 2021
…ated not the default VPC (ansible-collections#212)
alinabuzachis
pushed a commit
to alinabuzachis/community.aws
that referenced
this pull request
May 25, 2022
…#212) * Create initial test suite for ec2_metadata_facts Create an instance, run metadata on the remote instance, and teardown. * sanity fix * Trap cleanup so it always runs Add a wait_for_connection to test playbook Some minor cleanup * set tmp dirs for ec2 instance general cleanup * wait longer * run non_local; disabled coverage
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
#22 exposed a bug in the test - we were silently ignoring that the SG couldn't be attached.
ISSUE TYPE
COMPONENT NAME
ec2_metrics_alarm
ADDITIONAL INFORMATION
https://app.shippable.com/github/ansible-collections/community.aws/runs/655/37/console