ec2_instance - Use shared module implementation of get_ec2_security_group_ids_from_names #214
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ansibullbot
added
affects_2.10
bug
tremble
force-pushed
the
find_security_group/ec2_instance
branch
from
3e07b8f
to
aff0d39
Compare
tremble
force-pushed
the
find_security_group/ec2_instance
branch
from
aff0d39
to
5bf9bc7
Compare
…roup_ids_from_names
tremble
force-pushed
the
find_security_group/ec2_instance
branch
from
5bf9bc7
to
2d1cefe
Compare
jillr
approved these changes
Feb 10, 2021
ethemcemozkan
pushed a commit
to ethemcemozkan/community.aws
that referenced
this pull request
Feb 18, 2021
…roup_ids_from_names (ansible-collections#214) * ec2_instance - Use shared module implementation of get_ec2_security_group_ids_from_names * changelog
alinabuzachis
pushed a commit
to alinabuzachis/community.aws
that referenced
this pull request
Jul 19, 2021
…roup_ids_from_names (ansible-collections#214) * ec2_instance - Use shared module implementation of get_ec2_security_group_ids_from_names * changelog
alinabuzachis
pushed a commit
to alinabuzachis/community.aws
that referenced
this pull request
Jul 19, 2021
…roup_ids_from_names (ansible-collections#214) * ec2_instance - Use shared module implementation of get_ec2_security_group_ids_from_names * changelog
danielcotton
pushed a commit
to danielcotton/community.aws
that referenced
this pull request
Nov 23, 2021
…roup_ids_from_names (ansible-collections#214) * ec2_instance - Use shared module implementation of get_ec2_security_group_ids_from_names * changelog
alinabuzachis
pushed a commit
to alinabuzachis/community.aws
that referenced
this pull request
May 25, 2022
…fault Sanity test / doc-default-does-not-match-spec fixups
alinabuzachis
pushed a commit
to alinabuzachis/community.aws
that referenced
this pull request
May 25, 2022
…roup_ids_from_names (ansible-collections#214) * ec2_instance - Use shared module implementation of get_ec2_security_group_ids_from_names * changelog
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Fixes: #213
While working on #212 we spent a lot of time trying to debug the code in discover_security_groups. The bulk of this code is duplicated by module_utils.ec2.get_ec2_security_group_ids_from_names(). Let's use the shared code so we'll only need to test and debug one location in future.
Side effect: Where you have a mismatch between the security groups and the VPC of the selected subnets, this will now error with a warning like "Security group sg-0d67d5f78de12f7ce and subnet subnet-3f9eb911 belong to different networks." instead of silently dropping the security group on the floor.
ISSUE TYPE
COMPONENT NAME
ec2_instance
ADDITIONAL INFORMATION