Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sns_topic: Allow canonical international-format phone numbers in SMS subscriptions #454

Merged
merged 4 commits into from
Mar 8, 2021
Merged

sns_topic: Allow canonical international-format phone numbers in SMS subscriptions #454

merged 4 commits into from
Mar 8, 2021

Commits on Mar 3, 2021

  1. Update sns_topic.py 

    Adds `+` to the list of acceptable characters in an SMS endpoint.

Closes ansible-collections#453.
    @overhacked
    overhacked authored Mar 3, 2021
    Configuration menu
    Copy the full SHA
    519603c View commit details
    Browse the repository at this point in the history

Commits on Mar 5, 2021

  1. Add changelog fragment for ansible-collections#454

    @overhacked
    overhacked authored Mar 5, 2021
    Configuration menu
    Copy the full SHA
    5d8a889 View commit details
    Browse the repository at this point in the history

Commits on Mar 6, 2021

  1. sns_topic: comment explaining SMS canonicalization 

    Add comment documenting to what standard SMS endpoint addresses (phone
numbers) are canonicalized
    @overhacked
    overhacked committed Mar 6, 2021
    Configuration menu
    Copy the full SHA
    98e0f2e View commit details
    Browse the repository at this point in the history

Commits on Mar 8, 2021

  1. sns_topic: fix changelog 

    * Get quoting correct
* Simplify message to leave details in PR description

Co-authored-by: Mark Chappell <[email protected]>
    @overhacked @tremble
    overhacked and tremble authored Mar 8, 2021
    Configuration menu
    Copy the full SHA
    8c59a2f View commit details
    Browse the repository at this point in the history