sns_topic: Allow canonical international-format phone numbers in SMS subscriptions #454
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds `+` to the list of acceptable characters in an SMS endpoint. Closes ansible-collections#453.
overhacked
changed the title
ansibullbot
added
bug
|
Hi @overhacked, thank you for your contribution. May you kindly add a changelog https://docs.ansible.com/ansible/latest/community/development_process.html#changelogs? |
Add comment documenting to what standard SMS endpoint addresses (phone numbers) are canonicalized
tremble
requested changes
Mar 8, 2021
changelogs/fragments/454-sns_topic_fix_sms_endpoint_canonicalization.yaml
Outdated
Show resolved
Hide resolved
ansibullbot
added
needs_revision
* Get quoting correct * Simplify message to leave details in PR description Co-authored-by: Mark Chappell <[email protected]>
ansibullbot
added
community_review
and removed
needs_revision
tremble
approved these changes
Mar 8, 2021
|
Thanks for your submission |
danquixote
pushed a commit
to danquixote/community.aws
that referenced
this pull request
May 16, 2021
…subscriptions (ansible-collections#454) * Update sns_topic.py Adds `+` to the list of acceptable characters in an SMS endpoint. Closes ansible-collections#453. * Add changelog fragment for ansible-collections#454 * sns_topic: comment explaining SMS canonicalization Add comment documenting to what standard SMS endpoint addresses (phone numbers) are canonicalized * sns_topic: fix changelog * Get quoting correct * Simplify message to leave details in PR description Co-authored-by: Mark Chappell <[email protected]> Co-authored-by: Mark Chappell <[email protected]>
alinabuzachis
pushed a commit
to alinabuzachis/community.aws
that referenced
this pull request
Jul 19, 2021
…subscriptions (ansible-collections#454) * Update sns_topic.py Adds `+` to the list of acceptable characters in an SMS endpoint. Closes ansible-collections#453. * Add changelog fragment for ansible-collections#454 * sns_topic: comment explaining SMS canonicalization Add comment documenting to what standard SMS endpoint addresses (phone numbers) are canonicalized * sns_topic: fix changelog * Get quoting correct * Simplify message to leave details in PR description Co-authored-by: Mark Chappell <[email protected]> Co-authored-by: Mark Chappell <[email protected]>
alinabuzachis
pushed a commit
to alinabuzachis/community.aws
that referenced
this pull request
Jul 19, 2021
…subscriptions (ansible-collections#454) * Update sns_topic.py Adds `+` to the list of acceptable characters in an SMS endpoint. Closes ansible-collections#453. * Add changelog fragment for ansible-collections#454 * sns_topic: comment explaining SMS canonicalization Add comment documenting to what standard SMS endpoint addresses (phone numbers) are canonicalized * sns_topic: fix changelog * Get quoting correct * Simplify message to leave details in PR description Co-authored-by: Mark Chappell <[email protected]> Co-authored-by: Mark Chappell <[email protected]>
danielcotton
pushed a commit
to danielcotton/community.aws
that referenced
this pull request
Nov 23, 2021
…subscriptions (ansible-collections#454) * Update sns_topic.py Adds `+` to the list of acceptable characters in an SMS endpoint. Closes ansible-collections#453. * Add changelog fragment for ansible-collections#454 * sns_topic: comment explaining SMS canonicalization Add comment documenting to what standard SMS endpoint addresses (phone numbers) are canonicalized * sns_topic: fix changelog * Get quoting correct * Simplify message to leave details in PR description Co-authored-by: Mark Chappell <[email protected]> Co-authored-by: Mark Chappell <[email protected]>
alinabuzachis
pushed a commit
to alinabuzachis/community.aws
that referenced
this pull request
May 25, 2022
…>= 1.17.18 (ansible-collections#454) Don't check aws_az_info 'zone_type' it's only returned when botocore >= 1.17.18 SUMMARY AWS 'zone_type' info is only returned when botocore >= 1.17.18. Since we don't document what's returned we can get away with not testing this until the next botocore bump. ISSUE TYPE Tests Pull Request COMPONENT NAME aws_az_info ADDITIONAL INFORMATION Depends-On: ansible-collections#460 Reviewed-by: Alina Buzachis <None> Reviewed-by: None <None>
alinabuzachis
pushed a commit
to alinabuzachis/community.aws
that referenced
this pull request
May 25, 2022
…nsible-collections#404) Add constraints.txt and requirements.txt for unit/integration tests SUMMARY Now that we state that we support specific minimum versions of the AWS SDKs, make sure we base our unit/integration tests against them such that modules need to explicitly test/request newer versions of the SDKs. ISSUE TYPE Feature Pull Request COMPONENT NAME tests/integration tests/unit ADDITIONAL INFORMATION Once merged into amazon.aws we should merge this into community.aws Depends-On: ansible-collections#453 Depends-On: ansible-collections#454 Depends-On: ansible-collections#450 Depends-On: ansible-collections#496 See also: ansible/ansible-zuul-jobs#991 Reviewed-by: Jill R <None> Reviewed-by: None <None>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Adds
+to the list of acceptable characters in an SMS endpoint.Fixes #453.
ISSUE TYPE
COMPONENT NAME
sns_topic