Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added support for 'vpc_endpoint_type'. #460

Merged
merged 4 commits into from
Mar 7, 2021
Merged

Added support for 'vpc_endpoint_type'. #460

merged 4 commits into from
Mar 7, 2021

Conversation

Proksima
Copy link
Contributor

@Proksima Proksima commented Mar 5, 2021

SUMMARY

Add 'vpc_endpoint_type' support to 'ec2_vpc_endpoint'.

ISSUE TYPE
  • Feature Pull Request
COMPONENT NAME

ec2_vpc_endpoint

ADDITIONAL INFORMATION

@ansibullbot
Copy link

cc @Etherdaemon @jillr @s-hertel @tremble @wimnat
click here for bot help

@ansibullbot ansibullbot added community_review feature This issue/PR relates to a feature request module module needs_triage new_contributor Help guide this first time contributor plugins plugin (any type) labels Mar 5, 2021
@Proksima Proksima mentioned this pull request Mar 5, 2021
Closed
@Proksima
Copy link
Contributor Author

Proksima commented Mar 5, 2021 •
edited
Loading

Hmm, what is the procedure to get coverage? Should I write a test? I see no existing test for this module...

Nevermind, I found them. Will update the PR accordingly.

@ansibullbot ansibullbot added has_issue needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR and removed community_review labels Mar 5, 2021
@ansibullbot ansibullbot added integration tests/integration tests tests labels Mar 5, 2021
@ansibullbot ansibullbot added community_review and removed needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR labels Mar 5, 2021
tremble
tremble requested changes Mar 5, 2021
View reviewed changes
Copy link
Contributor

@tremble tremble left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for taking the time to raise this PR.

Generally looks good. I've just one small request: please add a changelog entry: https://docs.ansible.com/ansible/latest/community/development_process.html#changelogs-how-to

@ansibullbot ansibullbot added needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR and removed community_review labels Mar 5, 2021
@Proksima
Copy link
Contributor Author

Proksima commented Mar 5, 2021

Added changelog as requested!

@Proksima Proksima requested a review from tremble March 5, 2021 20:19
@tremble tremble linked an issue Mar 5, 2021 that may be closed by this pull request
Add support for vpc_endpoint_type in module ec2_vpc_endpoint. #459
Closed
@ansibullbot ansibullbot added community_review and removed needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR labels Mar 5, 2021
tremble
tremble approved these changes Mar 7, 2021
View reviewed changes
Copy link
Contributor

@tremble tremble left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tremble tremble merged commit 4da568a into ansible-collections:main Mar 7, 2021
tremble added a commit to tremble/community.aws that referenced this pull request Mar 7, 2021
@tremble
Fix version_added and changelog from ansible-collections#460
90005f0
tremble added a commit to tremble/community.aws that referenced this pull request Mar 7, 2021
@tremble
Fix version_added and changelog from ansible-collections#460
8efbd16
tremble added a commit that referenced this pull request Mar 8, 2021
@tremble
Fix version_added and changelog from #460 (#465)
4f8c366
danquixote pushed a commit to danquixote/community.aws that referenced this pull request May 16, 2021
@Proksima @danquixote
Added support for 'vpc_endpoint_type'. (ansible-collections#460)
7c8b8ab 
* Added support for 'vpc_endpoint_type'.
* Integration test for the 'vpc_endpoint_type' feature.
* Added choices in documentation.
* Added changelog.
danquixote pushed a commit to danquixote/community.aws that referenced this pull request May 16, 2021
@tremble @danquixote
Fix version_added and changelog from ansible-collections#460 (ansible…
221e94c 
…-collections#465)
alinabuzachis pushed a commit to alinabuzachis/community.aws that referenced this pull request Jul 16, 2021
@Proksima
[promoted]Added support for 'vpc_endpoint_type'. (ansible-collections…
e1686e8 
…#460)

* Added support for 'vpc_endpoint_type'.
* Integration test for the 'vpc_endpoint_type' feature.
* Added choices in documentation.
* Added changelog.

This commit was initially merged in https://github.com/ansible-collections/community.aws
See: ansible-collections@4da568a
alinabuzachis pushed a commit to alinabuzachis/community.aws that referenced this pull request Jul 16, 2021
@tremble
[promoted]Fix version_added and changelog from ansible-collections#460 (
91becc9 
ansible-collections#465)

This commit was initially merged in https://github.com/ansible-collections/community.aws
See: ansible-collections@4f8c366
alinabuzachis pushed a commit to alinabuzachis/community.aws that referenced this pull request Jul 19, 2021
@Proksima
Added support for 'vpc_endpoint_type'. (ansible-collections#460)
2f2d56f 
* Added support for 'vpc_endpoint_type'.
* Integration test for the 'vpc_endpoint_type' feature.
* Added choices in documentation.
* Added changelog.
alinabuzachis pushed a commit to alinabuzachis/community.aws that referenced this pull request Jul 19, 2021
@tremble
Fix version_added and changelog from ansible-collections#460 (ansible…
2fe418e 
…-collections#465)
alinabuzachis pushed a commit to alinabuzachis/community.aws that referenced this pull request Jul 19, 2021
@Proksima
Added support for 'vpc_endpoint_type'. (ansible-collections#460)
635c33d 
* Added support for 'vpc_endpoint_type'.
* Integration test for the 'vpc_endpoint_type' feature.
* Added choices in documentation.
* Added changelog.
alinabuzachis pushed a commit to alinabuzachis/community.aws that referenced this pull request Jul 19, 2021
@tremble
Fix version_added and changelog from ansible-collections#460 (ansible…
dcbc39b 
…-collections#465)
danielcotton pushed a commit to danielcotton/community.aws that referenced this pull request Nov 23, 2021
@Proksima @danielcotton
Added support for 'vpc_endpoint_type'. (ansible-collections#460)
68a479e 
* Added support for 'vpc_endpoint_type'.
* Integration test for the 'vpc_endpoint_type' feature.
* Added choices in documentation.
* Added changelog.
danielcotton pushed a commit to danielcotton/community.aws that referenced this pull request Nov 23, 2021
@tremble @danielcotton
Fix version_added and changelog from ansible-collections#460 (ansible…
2b7c2c6 
…-collections#465)
alinabuzachis pushed a commit to alinabuzachis/community.aws that referenced this pull request May 25, 2022
@tremble
Fixup / ignore new pylint 2.9.3 issues (ansible-collections#460)
d8caa6a 
Fixup / ignore new pylint 2.9.3 issues

SUMMARY
The devel containers have been updated to include a new version of pylint ( ansible-collections/overview#45 (comment) )
fixup arguments-renamed
fixup "raise None"
ignore pylint:use-a-generator (Should be an easy fix but not worth blocking gating)
ISSUE TYPE

Bugfix Pull Request

COMPONENT NAME
plugins/modules/ec2_instance.py
tests/sanity/ignore-2.12.txt
tests/unit/mock/loader.py
tests/unit/module_utils/test_elbv2.py
tests/unit/module_utils/test_s3.py
ADDITIONAL INFORMATION

Reviewed-by: Felix Fontein <None>
Reviewed-by: None <None>
Reviewed-by: Alina Buzachis <None>
alinabuzachis pushed a commit to alinabuzachis/community.aws that referenced this pull request May 25, 2022
@tremble
ec2_vol tests set requires to == rather than >= (so we can test the m…
feb9994 
…inimum we claim) (ansible-collections#453)

ec2_vol tests set botocore requires to == rather than >=

SUMMARY
We currently use >= which generally means that the latest version of botocore will be pulled in.  Given that we specify it's supposed to work with >= we should test the oldest possible version to ensure that we support at least that version.
ISSUE TYPE

Tests Pull Request

COMPONENT NAME
ec2_vol
ADDITIONAL INFORMATION
Depends-on: ansible-collections#460

Reviewed-by: None <None>
alinabuzachis pushed a commit to alinabuzachis/community.aws that referenced this pull request May 25, 2022
@tremble
aws_secret (lookup) - Add support for handling secrets marked for del…
54d313b 
…etion (ansible-collections#455)

aws_secret (lookup) - Add support for handling secrets marked for deletion

SUMMARY
Currently if you try to lookup a secret that's been marked for deletion it throws an uncaught exception.
ISSUE TYPE

Feature Pull Request

COMPONENT NAME
plugins/lookup/aws_secret.py
ADDITIONAL INFORMATION
Lack of support for this triggered a test failure
https://dashboard.zuul.ansible.com/t/ansible/build/69abfb39df9b4f71bc9b32aed8a2529b/log/job-output.txt
2021-08-11 09:04:12.324178 | fedora-34 | TASK [lookup_aws_secret : lookup missing secret] *******************************
2021-08-11 09:04:12.324419 | fedora-34 | task path: /home/zuul/.ansible/collections/ansible_collections/amazon/aws/tests/integration/targets/lookup_aws_secret/tasks/main.yaml:25
2021-08-11 09:04:12.807198 | fedora-34 | exception during Jinja2 execution: Traceback (most recent call last):
2021-08-11 09:04:12.807287 | fedora-34 |   File "/home/zuul/.ansible/collections/ansible_collections/amazon/aws/plugins/lookup/aws_secret.py", line 244, in get_secret_value
2021-08-11 09:04:12.807301 | fedora-34 |     response = client.get_secret_value(**params)
2021-08-11 09:04:12.807311 | fedora-34 |   File "/home/zuul/venv/lib/python3.6/site-packages/botocore/client.py", line 386, in _api_call
2021-08-11 09:04:12.807321 | fedora-34 |     return self._make_api_call(operation_name, kwargs)
2021-08-11 09:04:12.807330 | fedora-34 |   File "/home/zuul/venv/lib/python3.6/site-packages/botocore/client.py", line 705, in _make_api_call
2021-08-11 09:04:12.807339 | fedora-34 |     raise error_class(parsed_response, operation_name)
2021-08-11 09:04:12.807349 | fedora-34 | botocore.errorfactory.InvalidRequestException: An error occurred (InvalidRequestException) when calling the GetSecretValue operation: You can't perform this operation on the secret because it was marked for deletion.
2021-08-11 09:04:12.807359 | fedora-34 |
2021-08-11 09:04:12.807368 | fedora-34 | During handling of the above exception, another exception occurred:
2021-08-11 09:04:12.807377 | fedora-34 |
2021-08-11 09:04:12.807386 | fedora-34 | Traceback (most recent call last):
2021-08-11 09:04:12.807395 | fedora-34 |   File "/tmp/ansible-test-k5oaalo2/ansible/template/__init__.py", line 1014, in _lookup
2021-08-11 09:04:12.807404 | fedora-34 |     ran = instance.run(loop_terms, variables=self._available_variables, **kwargs)
2021-08-11 09:04:12.807413 | fedora-34 |   File "/home/zuul/.ansible/collections/ansible_collections/amazon/aws/plugins/lookup/aws_secret.py", line 220, in run
2021-08-11 09:04:12.807422 | fedora-34 |     on_missing=missing, on_denied=denied, nested=nested)
2021-08-11 09:04:12.807431 | fedora-34 |   File "/home/zuul/.ansible/collections/ansible_collections/amazon/aws/plugins/lookup/aws_secret.py", line 272, in get_secret_value
2021-08-11 09:04:12.807440 | fedora-34 |     raise AnsibleError("Failed to retrieve secret: %s" % to_native(e))
2021-08-11 09:04:12.807449 | fedora-34 | ansible.errors.AnsibleError: Failed to retrieve secret: An error occurred (InvalidRequestException) when calling the GetSecretValue operation: You can't perform this operation on the secret because it was marked for deletion.
2021-08-11 09:04:12.814937 | fedora-34 | fatal: [testhost]: FAILED! => {
2021-08-11 09:04:12.814987 | fedora-34 |     "msg": "An unhandled exception occurred while running the lookup plugin 'amazon.aws.aws_secret'. Error was a <class 'ansible.errors.AnsibleError'>, original message: Failed to retrieve secret: An error occurred (InvalidRequestException) when calling the GetSecretValue operation: You can't perform this operation on the secret because it was marked for deletion.. Failed to retrieve secret: An error occurred (InvalidRequestException) when calling the GetSecretValue operation: You can't perform this operation on the secret because it was marked for deletion."
2021-08-11 09:04:12.815002 | fedora-34 | }
2021-08-11 09:04:12.829452 | fedora-34 |

Depends-On: ansible-collections#460

Reviewed-by: Alina Buzachis <None>
Reviewed-by: Mark Chappell <None>
Reviewed-by: None <None>
alinabuzachis pushed a commit to alinabuzachis/community.aws that referenced this pull request May 25, 2022
@tremble
Don't check aws_az_info 'zone_type' it's only returned when botocore …
b1e6bfd 
…>= 1.17.18 (ansible-collections#454)

Don't check aws_az_info 'zone_type' it's only returned when botocore >= 1.17.18

SUMMARY
AWS 'zone_type' info is only returned when botocore >= 1.17.18.  Since we don't document what's returned we can get away with not testing this until the next botocore bump.
ISSUE TYPE

Tests Pull Request

COMPONENT NAME
aws_az_info
ADDITIONAL INFORMATION
Depends-On: ansible-collections#460

Reviewed-by: Alina Buzachis <None>
Reviewed-by: None <None>
alinabuzachis pushed a commit to alinabuzachis/community.aws that referenced this pull request May 25, 2022
@tremble
ec2_key : Fix tests (ansible-collections#427)
963a829 
ec2_key : Fix tests

SUMMARY
The Zuul nodes don't have OpenSSL installed on them, this breaks the generation of the fingerprints
ISSUE TYPE

Bugfix Pull Request

COMPONENT NAME
ec2_key
ADDITIONAL INFORMATION
https://dashboard.zuul.ansible.com/t/ansible/build/d79dcec2e3024558800bba5fd6917505/log/job-output.txt
"stderr": "/bin/sh: line 1: openssl: command not found"

Depends-on: ansible-collections#460

Reviewed-by: Alina Buzachis <None>
Reviewed-by: None <None>
alinabuzachis pushed a commit to alinabuzachis/community.aws that referenced this pull request May 25, 2022
@tremble
Remove vendored ipaddress library, we've dropped support for Python <…
535f9d0 
… 3.6 (ansible-collections#461)

Remove vendored ipaddress library, we've dropped support for Python < 3.6

SUMMARY
We've dropped support for Python < 3.6, and we're preparing for a major release.  Drop the vendored version of ipaddress
ISSUE TYPE

Feature Pull Request

COMPONENT NAME
plugins/module_utils/compat/_ipaddress.py
plugins/modules/ec2_group.py
ADDITIONAL INFORMATION
Depends-On: ansible-collections#460
Depends-On: ansible/ansible-zuul-jobs#1043
Depends-On: ansible/ansible-zuul-jobs#1055

Reviewed-by: Felix Fontein <None>
Reviewed-by: Alina Buzachis <None>
Reviewed-by: Jill R <None>
Reviewed-by: None <None>
alinabuzachis pushed a commit to alinabuzachis/community.aws that referenced this pull request May 25, 2022
@Proksima @alinabuzachis
Added support for 'vpc_endpoint_type'. (ansible-collections#460)
a28c113 
* Added support for 'vpc_endpoint_type'.
* Integration test for the 'vpc_endpoint_type' feature.
* Added choices in documentation.
* Added changelog.

This commit was initially merged in https://github.com/ansible-collections/community.aws
See: ansible-collections@4da568a
alinabuzachis pushed a commit to alinabuzachis/community.aws that referenced this pull request May 25, 2022
@tremble @alinabuzachis
Fix version_added and changelog from ansible-collections#460 (ansible…
d6dcb48 
…-collections#465)

This commit was initially merged in https://github.com/ansible-collections/community.aws
See: ansible-collections@4f8c366
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tremble tremble tremble approved these changes

Assignees
No one assigned
Labels
community_review feature This issue/PR relates to a feature request has_issue integration tests/integration module module needs_triage new_contributor Help guide this first time contributor plugins plugin (any type) tests tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add support for vpc_endpoint_type in module ec2_vpc_endpoint.
3 participants
@Proksima @ansibullbot @tremble