Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

elb_target_group - support target_type alb #966

Conversation

jatorcasso
Copy link
Contributor

SUMMARY
ISSUE TYPE
  • Feature Pull Request
COMPONENT NAME

elb_target_group

@ansibullbot
Copy link

@ansibullbot ansibullbot added community_review feature This issue/PR relates to a feature request integration tests/integration module module needs_triage plugins plugin (any type) tests tests labels Mar 5, 2022
Copy link
Contributor

@marknet15 marknet15 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

Copy link
Contributor

@mandar242 mandar242 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@markuman markuman added the backport-3 PR should be backported to the stable-3 branch label Mar 11, 2022
@markuman markuman added the mergeit Merge the PR (SoftwareFactory) label Mar 11, 2022
@softwarefactory-project-zuul softwarefactory-project-zuul bot merged commit 86741fe into ansible-collections:main Mar 11, 2022
@patchback
Copy link

patchback bot commented Mar 11, 2022

Backport to stable-3: 💚 backport PR created

✅ Backport PR branch: patchback/backports/stable-3/86741fed23c9022830396ae3b206203989b41b42/pr-966

Backported as #978

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

patchback bot pushed a commit that referenced this pull request Mar 11, 2022
elb_target_group - support target_type alb

SUMMARY

Add support for target_type alb and integration tests
Update documentation for clarity
Fixes #891

ISSUE TYPE

Feature Pull Request

COMPONENT NAME
elb_target_group

Reviewed-by: Mark Woolley <[email protected]>
Reviewed-by: Mandar Kulkarni <[email protected]>
Reviewed-by: Alina Buzachis <None>
Reviewed-by: Markus Bergholz <[email protected]>
(cherry picked from commit 86741fe)
softwarefactory-project-zuul bot pushed a commit that referenced this pull request Mar 11, 2022
[PR #966/86741fed backport][stable-3] elb_target_group - support target_type alb

This is a backport of PR #966 as merged into main (86741fe).
SUMMARY

Add support for target_type alb and integration tests
Update documentation for clarity
Fixes #891

ISSUE TYPE

Feature Pull Request

COMPONENT NAME
elb_target_group
abikouo pushed a commit to abikouo/community.aws that referenced this pull request Oct 24, 2023
… (ansible-collections#967)

fix ignore_nonexistent_bucket bug for listing (ansible-collections#966)

SUMMARY
remove duplicated use of bucket_check() and reuse bucketrtn instead
Fixes ansible-collections#966
ISSUE TYPE

Bugfix Pull Request

COMPONENT NAME
s3_object
ADDITIONAL INFORMATION

Reviewed-by: Mark Chappell <None>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-3 PR should be backported to the stable-3 branch community_review feature This issue/PR relates to a feature request integration tests/integration mergeit Merge the PR (SoftwareFactory) module module plugins plugin (any type) tests tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

elb_target_group: support target_type alb
6 participants