Add advanced options to vmware_cluster_vsan

[mariolenz]

Depends-On: #250

SUMMARY

While configuring vsan clusters, setting the advanced parameters for the vsan service (Object repair timer, Thin Swap, Large Cluster Support etc.) should be possible.

Fixes #260

ISSUE TYPE

• Feature Pull Request

COMPONENT NAME

vmware_cluster_vsan

ADDITIONAL INFORMATION

Unfortunately, this PR introduces a dependecy on the SAN Management vSDK for Python. On the other hand, using ReconfigureComputeResource_Task to configure VSAN is deprecated so we would need this SDK anyway sooner or later.

edit: vmware/pyvmomi#909

[Akasurde]

thanks for putting this together.

[mariolenz]

@lupa95 Can you please test this PR if it works for you?

[mariolenz]

@goneri

So, I would say, I'm ok to merge to patch BUT we must the extra dependency must be mentioned in the documentation, and if someone try to run the module without the dependency, the error message should be as clear as possible.

Are the documentation and the error message OK for you? I hope so, otherwise just tell me.

[mariolenz]

@goneri

vmware_vsan_health_info already depends on the vsan sdk (a.ka vSAN Management SDK for Python). [...] We cannot properly test the module in the CI, since we cannot easily pip install the depency.

It looks like the CI fails for exactly this reason, it fails to import the required Python library (vSAN Management SDK for Python). How do I exclude the module from CI tests? That is, integration tests... PEP8, pylint and so on should be OK I think.

[goneri]

You can disable the test by adding disabled in the tests/integration/targets/vmware_cluster_vsan/aliases file. It's still a good thing to have a functional test, even if we don't run it in the CI.

[goneri]

recheck

[goneri]

recheck

[mariolenz]

recheck

[mariolenz]

recheck

[mariolenz]

recheck

[goneri]

FYI @mariolenz, the following job of the ongoing CI run will fail: ansible-test-sanity-vmware, the problem will be resolved as soon as #250 is merged.

[mariolenz]

FYI @mariolenz, the following job of the ongoing CI run will fail: ansible-test-sanity-vmware, the problem will be resolved as soon as #250 is merged.

Thanks for the information. I've added Depends-On: #250 to this PR, maybe this will help.

[mariolenz]

Depends-On: #250 seems to have helped, but two jobs ran into a RETRY_LIMIT. I'll try again, maybe this was only a temporary problem.

[mariolenz]

recheck

[mariolenz]

@goneri The last CI run failed again, but not like the one before... I'll try with another run.

It looks like the CI pipeline is a bit inconsistent :-/

[mariolenz]

recheck

[goneri]

@goneri The last CI run failed again, but not like the one before... I'll try with another run.

It looks like the CI pipeline is a bit inconsistent :-/

Well, the last run is green :-). The long series of "Waiting on logger" is actually a bug in Zuul. It should go away as soon as we upgrade ( https://review.opendev.org/#/c/741257/ ).

[mariolenz]

@Akasurde @goneri

There were so many commits that I decided to squash them and do a force-push. But the changes you've requested should all be there.

Now that the last CI run is finally green, I've removed [WIP] from the PR title because I think it's fit for merging now.

[Akasurde]

@mariolenz I suggested some minor changes. Please ping me once done for merge.

[mariolenz]

@Akasurde I've committed the changes you've requested, but your first one was just a question. Do you want me to make it clearer that the requirement is vSAN 6.2 / ESXi 6.2U2 and later, but I've tested it only on 6.7?

[mariolenz]

recheck

[mariolenz]

@Akasurde What do you think, is this PR fit for merging now?