Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP - DO - NOT - MERGE - vmware_guest: honor esxi_hostname without template #357

Closed
wants to merge 1 commit into from
Closed

WIP - DO - NOT - MERGE - vmware_guest: honor esxi_hostname without template #357

wants to merge 1 commit into from

Conversation

goneri
Copy link
Member

@goneri goneri commented Aug 21, 2020

Use the esxi_hostname key to target the right host, even if
template key is not set.

Use the `esxi_hostname` key to target the right host, even if
`template` key is not set.
@goneri goneri changed the title vmware_guest: honor esxi_hostname without template WIP - DO - NOT - MERGE - vmware_guest: honor esxi_hostname without template Aug 21, 2020
@ansibullbot
Copy link

@goneri: Greetings! Thanks for taking the time to open this pullrequest. In order for the community to handle your pullrequest effectively, we need a bit more information.

Here are the items we could not find in your description:

  • issue type

Please set the description of this pullrequest with this template:
https://raw.githubusercontent.com/ansible/ansible/devel/.github/PULL_REQUEST_TEMPLATE.md

click here for bot help

@ansibullbot
Copy link

@ansibullbot ansibullbot added WIP Work in progress affects_2.10 module module needs_ci This PR requires CI testing to be performed. Please close and re-open this PR to trigger CI needs_info This issue requires further information. Please answer any outstanding questions needs_template This issue/PR has an incomplete description. Please fill in the proposed template correctly needs_triage Needs a first human triage before being processed. owner_pr PR created by owner/maintainer stale_ci CI is older than 7 days, rerun before merging labels Aug 21, 2020
@@ -3091,10 +3091,11 @@ def deploy_vm(self):
clonespec = None
clone_method = None
try:
# Only select specific host when ESXi hostname is provided
if self.params['esxi_hostname']:
self.relospec.host = self.select_host()
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't test this, but it looks like the else branch doesn't use self.relospec. I think you need to define the hostname to deploy to in self.relospec in the if branch, and in self.configspec in the else branch.

As I've said, I didn't test this. I'm just trying to understand what the code does and maybe I'm wrong.

@xenlo
Copy link
Contributor

xenlo commented Sep 24, 2020

I found where was the issue and proposed a PR # to fix it #400. So this PR can be closed.

Thanks @goneri and @mariolenz for your input!

@goneri
Copy link
Member Author

goneri commented Sep 24, 2020

Great, thanks @xenlo :-)

@goneri goneri closed this Sep 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
affects_2.10 cloud has_issue module module needs_ci This PR requires CI testing to be performed. Please close and re-open this PR to trigger CI needs_info This issue requires further information. Please answer any outstanding questions needs_template This issue/PR has an incomplete description. Please fill in the proposed template correctly needs_triage Needs a first human triage before being processed. owner_pr PR created by owner/maintainer plugins plugin (any type) stale_ci CI is older than 7 days, rerun before merging WIP Work in progress
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants