Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WIP - DO - NOT - MERGE - vmware_guest: honor esxi_hostname without template #357

Closed
wants to merge 1 commit into from
Closed

WIP - DO - NOT - MERGE - vmware_guest: honor esxi_hostname without template #357

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions plugins/modules/vmware_guest.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3091,10 +3091,11 @@ def deploy_vm(self):
clonespec = None
clone_method = None
try:
# Only select specific host when ESXi hostname is provided
if self.params['esxi_hostname']:
self.relospec.host = self.select_host()
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't test this, but it looks like the else branch doesn't use self.relospec. I think you need to define the hostname to deploy to in self.relospec in the if branch, and in self.configspec in the else branch.

As I've said, I didn't test this. I'm just trying to understand what the code does and maybe I'm wrong.


if self.params['template']:
# Only select specific host when ESXi hostname is provided
if self.params['esxi_hostname']:
self.relospec.host = self.select_host()
self.relospec.datastore = datastore

# Convert disk present in template if is set
Expand Down