Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix issue when using k8s_drain with disable_eviction set to yes #418

Merged
merged 1 commit into from
Mar 23, 2022
Merged

fix issue when using k8s_drain with disable_eviction set to yes #418

merged 1 commit into from
Mar 23, 2022

Conversation

abikouo
Copy link
Contributor

@abikouo abikouo commented Mar 22, 2022

SUMMARY

fixes #416

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

k8s_drain

ADDITIONAL INFORMATION

@abikouo abikouo mentioned this pull request Mar 22, 2022
Closed
Akasurde
Akasurde approved these changes Mar 22, 2022
View reviewed changes
Copy link
Member

@Akasurde Akasurde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@softwarefactory-project-zuul
Copy link

Build succeeded.

@bpedersen2
Copy link

The error is gone, LGTM!

@Akasurde
Copy link
Member

The error is gone, LGTM!

Thanks for the feedback.

@abikouo abikouo removed the request for review from gravesm March 23, 2022 08:59
@softwarefactory-project-zuul
Copy link

Build succeeded (gate pipeline).

@softwarefactory-project-zuul softwarefactory-project-zuul bot merged commit 074f0a6 into ansible-collections:main Mar 23, 2022
gravesm pushed a commit to gravesm/kubernetes.core that referenced this pull request Apr 28, 2022
@abikouo @gravesm
fix issue when using k8s_drain with disable_eviction set to yes (ansi…
0077819 
…ble-collections#418)

fix issue when using k8s_drain with disable_eviction set to yes

SUMMARY

fixes ansible-collections#416

ISSUE TYPE

Bugfix Pull Request

COMPONENT NAME

k8s_drain
ADDITIONAL INFORMATION

Reviewed-by: Abhijeet Kasurde <None>
(cherry picked from commit 074f0a6)
softwarefactory-project-zuul bot pushed a commit that referenced this pull request Apr 29, 2022
@gravesm
fix issue when using k8s_drain with disable_eviction set to yes (#418) (
321b6dc 
#440)

[backport/2.3] fix issue when using k8s_drain with disable_eviction set to yes (#418)

Depends-On: #446
fix issue when using k8s_drain with disable_eviction set to yes
SUMMARY
fixes #416
ISSUE TYPE
Bugfix Pull Request
COMPONENT NAME
k8s_drain
ADDITIONAL INFORMATION
Reviewed-by: Abhijeet Kasurde 
(cherry picked from commit 074f0a6)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Akasurde Akasurde Akasurde approved these changes

Assignees
No one assigned
Labels
mergeit
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Using k8s_drain with disable=yes results in error
3 participants
@abikouo @bpedersen2 @Akasurde