generated from ansible-collections/collection_template
-
Notifications
You must be signed in to change notification settings - Fork 135
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[backport/2.3] Upgrade black version (#424) #446
Merged
softwarefactory-project-zuul
merged 1 commit into
ansible-collections:stable-2.3
from
gravesm:backport/2.3/424
Apr 29, 2022
Merged
[backport/2.3] Upgrade black version (#424) #446
softwarefactory-project-zuul
merged 1 commit into
ansible-collections:stable-2.3
from
gravesm:backport/2.3/424
Apr 29, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Upgrade black version SUMMARY Move off of beta version of black and pin to current calendar year version. The only manual changes here are to tox.ini. Everything else is from running the new version of black. ISSUE TYPE COMPONENT NAME ADDITIONAL INFORMATION Reviewed-by: Abhijeet Kasurde <None> (cherry picked from commit 7c71436)
This was referenced Apr 28, 2022
recheck |
recheck |
recheck |
recheck |
recheck |
recheck |
softwarefactory-project-zuul
bot
merged commit Apr 29, 2022
68d45af
into
ansible-collections:stable-2.3
softwarefactory-project-zuul bot
pushed a commit
that referenced
this pull request
Apr 29, 2022
#440) [backport/2.3] fix issue when using k8s_drain with disable_eviction set to yes (#418) Depends-On: #446 fix issue when using k8s_drain with disable_eviction set to yes SUMMARY fixes #416 ISSUE TYPE Bugfix Pull Request COMPONENT NAME k8s_drain ADDITIONAL INFORMATION Reviewed-by: Abhijeet Kasurde (cherry picked from commit 074f0a6)
softwarefactory-project-zuul bot
pushed a commit
that referenced
this pull request
May 2, 2022
[backport/2.3] Remove omit from template resource (#432) Depends-On: #446 Remove omit value from template args SUMMARY While defining resource using template parameter, the code does not remove the omit value if any. This fix adds a post process to remove any omit value from the resource definition. fixes #431 ISSUE TYPE Bugfix Pull Request COMPONENT NAME k8s* Reviewed-by: Mike Graves [email protected] Reviewed-by: Abhijeet Kasurde (cherry picked from commit 882e672)
softwarefactory-project-zuul bot
pushed a commit
that referenced
this pull request
May 2, 2022
[backport/2.3] Change line in doc fragment yaml (#439) Depends-On: #446 Change line in doc fragment yaml SUMMARY For whatever reason, the one line in this doc fragment leads to sanity failures in the redhat.openshift collection, which uses this fragment. The downstream build process for that collection creates yaml that appears to be valid, but that fails to lint. I'm not sure exactly which tool the problem is in, but the easiest solution is to just remove the single quotes here. ISSUE TYPE Docs Pull Request COMPONENT NAME ADDITIONAL INFORMATION Reviewed-by: Abhijeet Kasurde (cherry picked from commit b5cfc85)
softwarefactory-project-zuul bot
pushed a commit
that referenced
this pull request
May 2, 2022
) [backport/2.3] continue waiting when an exception is raised (#408) Depends-On: #446 Continue waiting when an exception is raised SUMMARY When an exception is raised and the wait_timeout is not reached, we should continue waiting as this may occurs due to temporary issue on cluster Fixes #407 ISSUE TYPE Bugfix Pull Request COMPONENT NAME ADDITIONAL INFORMATION Reviewed-by: Mike Graves [email protected] Reviewed-by: Abhijeet Kasurde (cherry picked from commit f418353)
softwarefactory-project-zuul bot
pushed a commit
that referenced
this pull request
May 2, 2022
…tion (#434) (#444) [backport/2.3] k8s - fix issue when try to delete resources using label_selectors op… Depends-On: #446 k8s - fix issue when try to delete resources using label_selectors SUMMARY The kubernetes dynamic client has label_selector parameter for the delete method, however based on the documentation of REST API we cannot delete resources using labelSelector option, this fix update the way the resources are deleted. The list of resources are deleted one after another like in the kubectl go client. Fixes #428 ISSUE TYPE Bugfix Pull Request Reviewed-by: Abhijeet Kasurde (cherry picked from commit f2f4b66)
softwarefactory-project-zuul bot
pushed a commit
that referenced
this pull request
May 2, 2022
[backport/2.3] k8s_cp - fix issue when using local_path (#422) Depends-On: #446 k8s_cp - fix issue when using local_path SUMMARY When copying from local path to pod, the file is found on the controller node instead of the managed node. This PR aims to resolve this issue. Fixes #421 ISSUE TYPE Bugfix Pull Request COMPONENT NAME k8s_cp Reviewed-by: Abhijeet Kasurde Reviewed-by: Mike Graves [email protected] (cherry picked from commit 1d05cf5)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends-On: ansible/ansible-zuul-jobs#1515
Upgrade black version
SUMMARY
Move off of beta version of black and pin to current calendar year
version.
The only manual changes here are to tox.ini. Everything else is from running the new version of black.
ISSUE TYPE
COMPONENT NAME
ADDITIONAL INFORMATION
Reviewed-by: Abhijeet Kasurde
(cherry picked from commit 7c71436)