fix: kustomize plugin fails with deprecation warnings #728

qcu266 · 2024-05-24T10:44:50Z

SUMMARY

error judgments are based on the exit codes of command execution, where 0 represents success and non-zero represents failure.

Optimize the run_command function to return a tuple like the run_command method of AnsibleModule.

Fixes #639

ISSUE TYPE

Bugfix Pull Request

COMPONENT NAME

kustomize lookup plugin

ADDITIONAL INFORMATION

softwarefactory-project-zuul · 2024-05-24T11:00:21Z

Build succeeded.
https://ansible.softwarefactory-project.io/zuul/buildset/7e4c479585ec4f05b7d804211871b0d5

✔️ ansible-galaxy-importer SUCCESS in 5m 36s
✔️ build-ansible-collection SUCCESS in 8m 24s

softwarefactory-project-zuul · 2024-05-25T11:12:17Z

Build succeeded.
https://ansible.softwarefactory-project.io/zuul/buildset/93353af2584a45328154e886ae561b56

✔️ ansible-galaxy-importer SUCCESS in 3m 51s
✔️ build-ansible-collection SUCCESS in 8m 07s

gravesm

Can you add changelog fragment please?

softwarefactory-project-zuul · 2024-06-20T14:47:07Z

Build succeeded.
https://ansible.softwarefactory-project.io/zuul/buildset/f2bbf2e0325a44d1b0d0554a8572f854

✔️ ansible-galaxy-importer SUCCESS in 3m 52s
✔️ build-ansible-collection SUCCESS in 6m 45s

qcu266 · 2024-06-24T09:54:04Z

@gravesm I have already added the changelog fragment. please review again.

gravesm · 2024-07-09T12:49:34Z

changelogs/fragments/20240620-fix-kustomize-plugin-fails-with-deprecation-warnings.yml

The changelog fragment is empty.

softwarefactory-project-zuul · 2024-07-10T15:05:19Z

Build succeeded.
https://ansible.softwarefactory-project.io/zuul/buildset/4918ae9fedcd4a08a8331a4b4947b87e

✔️ ansible-galaxy-importer SUCCESS in 4m 36s
✔️ build-ansible-collection SUCCESS in 7m 12s

gravesm

You have some spacing and indentation issues that are causing linters to fail. I think the one integration test failure should be solved by rebasing.

gravesm · 2024-07-10T15:23:23Z

plugins/lookup/kustomize.py

@@ -94,7 +94,8 @@ def get_binary_from_path(name, opt_dirs=None):

 def run_command(command):
    cmd = subprocess.Popen(command, stdout=subprocess.PIPE, stderr=subprocess.PIPE)
-    return cmd.communicate()
+    stdout, stderr = cmd.communicate()
+    return  cmd.returncode, stdout, stderr


Suggested change

return cmd.returncode, stdout, stderr

return cmd.returncode, stdout, stderr

gravesm · 2024-07-10T15:23:50Z

plugins/lookup/kustomize.py

+          if err:
            raise AnsibleLookupError(
-                "kustomize command failed with: {0}".format(err.decode("utf-8"))
+                "kustomize command failed. exit code: {0}, error: {1}".format(ret, err.decode("utf-8"))
+            )
+          else:
+            raise AnsibleLookupError(
+                "kustomize command failed with unknown error. exit code: {0}".format(ret)


This is not a full indentation.

softwarefactory-project-zuul · 2024-07-11T12:38:36Z

Build succeeded.
https://ansible.softwarefactory-project.io/zuul/buildset/35e0d6525bd64aea96c2dd6a58a7776f

✔️ ansible-galaxy-importer SUCCESS in 4m 41s
✔️ build-ansible-collection SUCCESS in 6m 35s

softwarefactory-project-zuul · 2024-07-15T13:09:17Z

Build succeeded.
https://ansible.softwarefactory-project.io/zuul/buildset/f1fb503865b342a8bb274539996a88a8

✔️ ansible-galaxy-importer SUCCESS in 4m 37s
✔️ build-ansible-collection SUCCESS in 6m 48s

softwarefactory-project-zuul · 2024-07-15T13:29:21Z

Build succeeded (gate pipeline).
https://ansible.softwarefactory-project.io/zuul/buildset/52c6f23c7d8a4267a4a025e9ed637a20

✔️ ansible-galaxy-importer SUCCESS in 4m 31s
✔️ build-ansible-collection SUCCESS in 6m 45s

patchback · 2024-07-15T13:29:26Z

Backport to stable-3: 💚 backport PR created

✅ Backport PR branch: patchback/backports/stable-3/5bc53dba7ceb75a5fb998f04d10bec7a20b27ee9/pr-728

Backported as #763

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

SUMMARY error judgments are based on the exit codes of command execution, where 0 represents success and non-zero represents failure. Optimize the run_command function to return a tuple like the run_command method of AnsibleModule. Fixes #639 ISSUE TYPE Bugfix Pull Request COMPONENT NAME kustomize lookup plugin ADDITIONAL INFORMATION Reviewed-by: Mike Graves <[email protected]> Reviewed-by: QCU (cherry picked from commit 5bc53db)

patchback · 2024-07-15T13:29:32Z

Backport to stable-5: 💚 backport PR created

✅ Backport PR branch: patchback/backports/stable-5/5bc53dba7ceb75a5fb998f04d10bec7a20b27ee9/pr-728

Backported as #764

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

SUMMARY error judgments are based on the exit codes of command execution, where 0 represents success and non-zero represents failure. Optimize the run_command function to return a tuple like the run_command method of AnsibleModule. Fixes #639 ISSUE TYPE Bugfix Pull Request COMPONENT NAME kustomize lookup plugin ADDITIONAL INFORMATION Reviewed-by: Mike Graves <[email protected]> Reviewed-by: QCU (cherry picked from commit 5bc53db)

This is a backport of PR #728 as merged into main (5bc53db). SUMMARY error judgments are based on the exit codes of command execution, where 0 represents success and non-zero represents failure. Optimize the run_command function to return a tuple like the run_command method of AnsibleModule. Fixes #639 ISSUE TYPE Bugfix Pull Request COMPONENT NAME kustomize lookup plugin ADDITIONAL INFORMATION Reviewed-by: Mike Graves <[email protected]>

qcu266 force-pushed the fix/kustomize-deprecation-warnings branch from 64fe1e3 to 8b43cdf Compare May 25, 2024 10:59

gravesm reviewed Jun 17, 2024

View reviewed changes

qcu266 added a commit to qcu266/kubernetes.core that referenced this pull request Jun 20, 2024

chore: add changelog fragment for PR ansible-collections#728

0f0fc84

gravesm reviewed Jul 9, 2024

View reviewed changes

qcu266 added a commit to qcu266/kubernetes.core that referenced this pull request Jul 10, 2024

chore: add changelog fragment for PR ansible-collections#728

c1a884e

qcu266 force-pushed the fix/kustomize-deprecation-warnings branch from 0f0fc84 to c1a884e Compare July 10, 2024 14:52

gravesm reviewed Jul 10, 2024

View reviewed changes

qcu266 added 2 commits July 11, 2024 20:24

fix: kustomize plugin fails with deprecation warnings

b7f5738

chore: add changelog fragment for PR ansible-collections#728

2fbc888

qcu266 force-pushed the fix/kustomize-deprecation-warnings branch from c1a884e to b6b9762 Compare July 11, 2024 12:25

fix: some format incorrect

47f5e2a

qcu266 force-pushed the fix/kustomize-deprecation-warnings branch from b6b9762 to 47f5e2a Compare July 11, 2024 12:26

Fix linting

7ff1a2c

gravesm approved these changes Jul 15, 2024

View reviewed changes

gravesm added mergeit backport-3 backport-5 labels Jul 15, 2024

softwarefactory-project-zuul bot merged commit 5bc53db into ansible-collections:main Jul 15, 2024
39 checks passed

patchback bot mentioned this pull request Jul 15, 2024

[PR #728/5bc53dba backport][stable-3] fix: kustomize plugin fails with deprecation warnings #763

Merged

patchback bot mentioned this pull request Jul 15, 2024

[PR #728/5bc53dba backport][stable-5] fix: kustomize plugin fails with deprecation warnings #764

Merged

qcu266 deleted the fix/kustomize-deprecation-warnings branch July 16, 2024 15:51

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: kustomize plugin fails with deprecation warnings #728

fix: kustomize plugin fails with deprecation warnings #728

qcu266 commented May 24, 2024

softwarefactory-project-zuul bot commented May 24, 2024

softwarefactory-project-zuul bot commented May 25, 2024

gravesm left a comment

softwarefactory-project-zuul bot commented Jun 20, 2024

qcu266 commented Jun 24, 2024

gravesm Jul 9, 2024

qcu266 Jul 10, 2024

softwarefactory-project-zuul bot commented Jul 10, 2024

gravesm left a comment

gravesm Jul 10, 2024

gravesm Jul 10, 2024

softwarefactory-project-zuul bot commented Jul 11, 2024

softwarefactory-project-zuul bot commented Jul 15, 2024

softwarefactory-project-zuul bot commented Jul 15, 2024

patchback bot commented Jul 15, 2024 •

edited

Loading

patchback bot commented Jul 15, 2024 •

edited

Loading

	return cmd.returncode, stdout, stderr
	return cmd.returncode, stdout, stderr

fix: kustomize plugin fails with deprecation warnings #728

fix: kustomize plugin fails with deprecation warnings #728

Conversation

qcu266 commented May 24, 2024

SUMMARY

ISSUE TYPE

COMPONENT NAME

ADDITIONAL INFORMATION

softwarefactory-project-zuul bot commented May 24, 2024

softwarefactory-project-zuul bot commented May 25, 2024

gravesm left a comment

Choose a reason for hiding this comment

softwarefactory-project-zuul bot commented Jun 20, 2024

qcu266 commented Jun 24, 2024

gravesm Jul 9, 2024

Choose a reason for hiding this comment

qcu266 Jul 10, 2024

Choose a reason for hiding this comment

softwarefactory-project-zuul bot commented Jul 10, 2024

gravesm left a comment

Choose a reason for hiding this comment

gravesm Jul 10, 2024

Choose a reason for hiding this comment

gravesm Jul 10, 2024

Choose a reason for hiding this comment

softwarefactory-project-zuul bot commented Jul 11, 2024

softwarefactory-project-zuul bot commented Jul 15, 2024

softwarefactory-project-zuul bot commented Jul 15, 2024

patchback bot commented Jul 15, 2024 • edited Loading

Backport to stable-3: 💚 backport PR created

patchback bot commented Jul 15, 2024 • edited Loading

Backport to stable-5: 💚 backport PR created

patchback bot commented Jul 15, 2024 •

edited

Loading

patchback bot commented Jul 15, 2024 •

edited

Loading