[PR #728/5bc53dba backport][stable-3] fix: kustomize plugin fails with deprecation warnings #763
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![patchback[bot]](https://avatars.githubusercontent.com/in/21488?s=60&v=4){kind=small}
SUMMARY error judgments are based on the exit codes of command execution, where 0 represents success and non-zero represents failure. Optimize the run_command function to return a tuple like the run_command method of AnsibleModule. Fixes #639 ISSUE TYPE Bugfix Pull Request COMPONENT NAME kustomize lookup plugin ADDITIONAL INFORMATION Reviewed-by: Mike Graves <[email protected]> Reviewed-by: QCU (cherry picked from commit 5bc53db)
|
Build succeeded. ✔️ ansible-galaxy-importer SUCCESS in 7m 45s |
gravesm
approved these changes
Jul 15, 2024
|
Build succeeded (gate pipeline). ✔️ ansible-galaxy-importer SUCCESS in 4m 39s |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a backport of PR #728 as merged into main (5bc53db).
SUMMARY
error judgments are based on the exit codes of command execution, where 0 represents success and non-zero represents failure.
Optimize the run_command function to return a tuple like the run_command method of AnsibleModule.
Fixes #639
ISSUE TYPE
COMPONENT NAME
kustomize lookup plugin
ADDITIONAL INFORMATION