-
Notifications
You must be signed in to change notification settings - Fork 91
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving this based on the general philosophy that formatters free up our time and CPU cycles so they can be used on user-facing features and resolving user-facing issues.
That said, I will defer to @tomaciazek @ganeshrn and @priyamsahoo here to decide if this gets merged.
@ssbarnea, I agree with @webknjaz that you should have waited for his review before merging #181, as he did explicitly state opposition to these changes in #177.
@webknjaz, are you saying that you'll approve this one once #181 is reverted? But that will inevitably break/change markdown files on every save, as explained in #177 ;) @ssbarnea, @webknjaz could you please create a discussion similar to ansible/team-devtools#28, where everyone can express their opinion in a well-structured format, since this is obviously a polarizing topic? The changes introduced here aren't urgent, so I don't see a reason not to take time to discuss them. |
Follow-Up: ansible#215 Increases the scope of markdown files prettier will clean-up to include the docs directory and includes changes to those files made by prettier.
for more information, see https://pre-commit.ci
I'm just saying that merging stuff with rejections or no reviews is a bad tone unless agreed offline. These things cascade and become harder to For now, I've lost interest in trying to review this as it doesn't feel like it'd matter anymore. This is why I'm just going to approve it. |
Follow-Up: #215
Increases the scope of markdown files prettier will clean-up to include the docs directory and includes changes to those files made by prettier.