Avoid running docker tests with podman-docker (#2457)

Relates: #2456

Signed-off-by: Sorin Sbarnea <[email protected]>

molecule/command/init/role.py

@@ -19,19 +19,14 @@
 #  DEALINGS IN THE SOFTWARE.
 
 import os
-import sys
 import click
+import subprocess
 from molecule import api
 from molecule import logger
 from molecule import util
 from molecule.command import base as command_base
 from molecule.command.init import base
 
-if os.name == 'posix' and sys.version_info[0] < 3:
-    import subprocess32 as subprocess
-else:
-    import subprocess
-
 
 LOG = logger.get_logger(__name__)
 
@@ -77,9 +72,7 @@ def execute(self):
 
         try:
             cmd = ["ansible-galaxy", "init", "-v", "--offline", role_name]
-            subprocess.check_output(
-                cmd, stderr=subprocess.STDOUT, universal_newlines=True
-            )
+            util.check_output(cmd, stderr=subprocess.STDOUT, universal_newlines=True)
         except Exception as e:
             util.sysexit_with_message(
                 "Galaxy failed to create role: %s: %s" % (e, e.output)

molecule/test/functional/conftest.py

@@ -28,6 +28,7 @@
 import pexpect
 import pytest
 import sh
+from subprocess import PIPE
 
 from molecule import logger
 from molecule import util
@@ -246,7 +247,22 @@ def get_virtualbox_executable():
 
 @pytest.helpers.register
 def supports_docker():
-    return get_docker_executable()
+    docker = get_docker_executable()
+    if docker:
+        result = util.run([docker, "info"], stdout=PIPE, universal_newlines=True)
+        if result.returncode != 0:
+            LOG.error(
+                "Error %s returned from `docker info`: %s",
+                result.returncode,
+                result.stdout,
+            )
+            return False
+        if "BuildahVersion" in result.stdout:
+            LOG.error(
+                "podman-docker is unsupported, see https://github.com/ansible/molecule/issues/2456"
+            )
+            return False
+    return True
 
 
 def min_ansible(version):

molecule/util.py

@@ -26,6 +26,13 @@
 import re
 import sys
 
+try:
+    from subprocess import check_output  # noqa 401
+    from subprocess import run  # noqa 401
+except ImportError:
+    from subprocess32 import check_output  # noqa 401
+    from subprocess32 import run  # noqa 401
+
 try:
     from collections.abc import Mapping
 except ImportError:  # Python 2 compatibility