Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid running docker tests with podman-docker #2457

Merged
merged 1 commit into from
Dec 7, 2019
Merged

Avoid running docker tests with podman-docker #2457

merged 1 commit into from
Dec 7, 2019

Conversation

ssbarnea
Copy link
Member

Relates: #2456

@ssbarnea ssbarnea self-assigned this Nov 30, 2019
@ssbarnea ssbarnea added podman skip-changelog test Improvement to quality assurance: CI/CD, testing, building labels Nov 30, 2019
@ssbarnea ssbarnea marked this pull request as ready for review December 1, 2019 16:36
@ssbarnea ssbarnea mentioned this pull request Dec 2, 2019
Closed
sshnaidm
sshnaidm approved these changes Dec 7, 2019
View reviewed changes
Copy link
Contributor

@sshnaidm sshnaidm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This podman-docker seems like a dangerous and breaking thing, by covering basic use-cases it breaks all the rest.

@sshnaidm sshnaidm merged commit b94c527 into ansible:master Dec 7, 2019
@ssbarnea ssbarnea deleted the fix/podman-detection branch October 23, 2020 17:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sshnaidm sshnaidm sshnaidm approved these changes

@cloudnull cloudnull Awaiting requested review from cloudnull

@LukeShortCloud LukeShortCloud Awaiting requested review from LukeShortCloud

@decentral1se decentral1se Awaiting requested review from decentral1se

Assignees

@ssbarnea ssbarnea

@cloudnull cloudnull

@sshnaidm sshnaidm

@LukeShortCloud LukeShortCloud

Labels
skip-changelog test Improvement to quality assurance: CI/CD, testing, building
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ssbarnea @sshnaidm @cloudnull @LukeShortCloud