Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ANSIBLE_FORCE_COLOR can prevent extension from working correctly #373

Closed
ssbarnea opened this issue Jan 13, 2022 · 2 comments · Fixed by ansible/ansible-language-server#236
Closed

ANSIBLE_FORCE_COLOR can prevent extension from working correctly #373

ssbarnea opened this issue Jan 13, 2022 · 2 comments · Fixed by ansible/ansible-language-server#236
Labels
bug Something isn't working

Comments

@ssbarnea
Copy link
Member

ssbarnea commented Jan 13, 2022 •
edited
Loading

After a debugging session with @priyamsahoo we found what is preventing our extension from working correctly for some users.

If you happen to have ANSIBLE_FORCE_COLOR=1 inside shell environment, user ansible.cfg or project specific config, it will break our extension, likely because we try to parse the output as JSON in one or more places without explicitly disabling the coloring on those commands.

Our extension should work regardless how user configured that variable, or others.
@ssbarnea ssbarnea added the bug Something isn't working label Jan 13, 2022
@priyamsahoo
Copy link
Contributor

The appropriate code to set and unset the values should go into the ansible-language-server code base.

priyamsahoo added a commit to priyamsahoo/vscode-ansible that referenced this issue Jan 13, 2022
@priyamsahoo
fix failure because of ANSIBLE_FORCE_COLOR (fixes ansible#373)
b282756
@ssbarnea ssbarnea reopened this Jan 14, 2022
@ssbarnea
Copy link
Member Author

This bug should be closed only when we update ALS.

@ssbarnea ssbarnea mentioned this issue Jan 14, 2022
Closed
ssbarnea added a commit to ssbarnea/ansible-language-server that referenced this issue Jan 18, 2022
@ssbarnea
Ensure ansible output is parsable
7af3312 
In order to avoid erroring parsing output on system where the
user may have configured ansible to always use color, we inject
an override of that option before executing external commands.

This affects both ansible and ansible-lint.

Related: ansible/vscode-ansible#373
@ssbarnea ssbarnea mentioned this issue Jan 18, 2022
Closed
ssbarnea added a commit to ssbarnea/ansible-language-server that referenced this issue Jan 18, 2022
@ssbarnea
Ensure ansible output is parsable
d0edb4d 
In order to avoid erroring parsing output on system where the
user may have configured ansible to always use color, we inject
an override of that option before executing external commands.

This affects both ansible and ansible-lint.

Related: ansible/vscode-ansible#373
ssbarnea added a commit to ssbarnea/ansible-language-server that referenced this issue Jan 19, 2022
@ssbarnea
Ensure ansible output is parsable
6510bbf 
In order to avoid erroring parsing output on system where the
user may have configured ansible to always use color, we inject
an override of that option before executing external commands.

This affects both ansible and ansible-lint.

Related: ansible/vscode-ansible#373
ssbarnea added a commit to ssbarnea/ansible-language-server that referenced this issue Jan 19, 2022
@ssbarnea
Ensure ansible output is parsable
bf8592b 
In order to avoid erroring parsing output on system where the
user may have configured ansible to always use color, we inject
an override of that option before executing external commands.

This affects both ansible and ansible-lint.

Related: ansible/vscode-ansible#373
ssbarnea added a commit to ssbarnea/ansible-language-server that referenced this issue Jan 19, 2022
@ssbarnea
Ensure ansible output is parsable
09168c5 
In order to avoid erroring parsing output on system where the
user may have configured ansible to always use color, we inject
an override of that option before executing external commands.

This affects both ansible and ansible-lint.

Related: ansible/vscode-ansible#373
ssbarnea added a commit to ssbarnea/ansible-language-server that referenced this issue Jan 20, 2022
@ssbarnea
Ensure ansible output is parsable
211d276 
In order to avoid erroring parsing output on system where the
user may have configured ansible to always use color, we inject
an override of that option before executing external commands.

This affects both ansible and ansible-lint.

Related: ansible/vscode-ansible#373
ssbarnea added a commit to ssbarnea/ansible-language-server that referenced this issue Jan 20, 2022
@ssbarnea
Ensure ansible output is parsable
afc7207 
In order to avoid erroring parsing output on system where the
user may have configured ansible to always use color, we inject
an override of that option before executing external commands.

This affects both ansible and ansible-lint.

Related: ansible/vscode-ansible#373
ssbarnea added a commit to ssbarnea/ansible-language-server that referenced this issue Jan 27, 2022
@ssbarnea
Make runCommand strip ANSI codes
221202c 
This makes runCommand automatically strip ANSI escapes from stdout
and stderr, while still allowing user to opt-in for not stripping
them.

The reason for using stripping by default is that the primary use
case for runCommand is to process the output and not to display it
inside a terminal. This should prevent bugs where we fail to parse
the output from various tools due to presence of ANSI codes.

Related: ansible/vscode-ansible#373
@ssbarnea ssbarnea mentioned this issue Jan 27, 2022
Closed
ssbarnea added a commit to ssbarnea/ansible-language-server that referenced this issue Jan 27, 2022
@ssbarnea
Make runCommand strip ANSI codes
db21f7a 
This makes runCommand automatically strip ANSI escapes from stdout
and stderr, while still allowing user to opt-in for not stripping
them.

The reason for using stripping by default is that the primary use
case for runCommand is to process the output and not to display it
inside a terminal. This should prevent bugs where we fail to parse
the output from various tools due to presence of ANSI codes.

Related: ansible/vscode-ansible#373
ssbarnea added a commit to ssbarnea/ansible-language-server that referenced this issue Jan 27, 2022
@ssbarnea
Make runCommand strip ANSI codes
376994c 
This makes runCommand automatically strip ANSI escapes from stdout
and stderr, while still allowing user to opt-in for not stripping
them.

The reason for using stripping by default is that the primary use
case for runCommand is to process the output and not to display it
inside a terminal. This should prevent bugs where we fail to parse
the output from various tools due to presence of ANSI codes.

Related: ansible/vscode-ansible#373
ssbarnea added a commit to ssbarnea/ansible-language-server that referenced this issue Jan 27, 2022
@ssbarnea
Make runCommand strip ANSI codes
fb8171f 
This makes runCommand automatically strip ANSI escapes from stdout
and stderr, while still allowing user to opt-in for not stripping
them.

The reason for using stripping by default is that the primary use
case for runCommand is to process the output and not to display it
inside a terminal. This should prevent bugs where we fail to parse
the output from various tools due to presence of ANSI codes.

Related: ansible/vscode-ansible#373
ssbarnea added a commit to ssbarnea/ansible-language-server that referenced this issue Mar 1, 2022
@ssbarnea
Ensure ansible output is parseable
2313a04 
Closes: ansible/vscode-ansible#373
Closes: ansible#173
Closes: ansible#194
@ssbarnea ssbarnea mentioned this issue Mar 1, 2022
Merged
ssbarnea added a commit to ssbarnea/ansible-language-server that referenced this issue Mar 1, 2022
@ssbarnea
Ensure ansible output is parseable
3f894ba 
Closes: ansible/vscode-ansible#373
Closes: ansible#173
Closes: ansible#194
ssbarnea added a commit to ssbarnea/ansible-language-server that referenced this issue Mar 1, 2022
@ssbarnea
Ensure ansible output is parseable
eb72f1e 
Closes: ansible/vscode-ansible#373
Closes: ansible#173
Closes: ansible#194
ssbarnea added a commit to ssbarnea/ansible-language-server that referenced this issue Mar 1, 2022
@ssbarnea
Ensure ansible output is parseable
28cb6fe 
Closes: ansible/vscode-ansible#373
Closes: ansible#173
Closes: ansible#194
@github-actions github-actions bot mentioned this issue Mar 1, 2022
Merged
ssbarnea added a commit that referenced this issue Mar 15, 2024
@ssbarnea
Update release task (#373)
e2ab7a7
@ssbarnea ssbarnea mentioned this issue Mar 15, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Ensure ansible output is parseable ssbarnea/ansible-language-server
2 participants
@ssbarnea @priyamsahoo